Skip to content

Commit e404a69

Browse files
authored
fix(compiler-sfc): handle dynamic directive arguments in template usage check (#8538)
close #8537
1 parent f07cb18 commit e404a69

File tree

3 files changed

+40
-0
lines changed

3 files changed

+40
-0
lines changed

packages/compiler-sfc/__tests__/__snapshots__/compileScript.spec.ts.snap

+15
Original file line numberDiff line numberDiff line change
@@ -745,6 +745,21 @@ return { get vMyDir() { return vMyDir } }
745745
})"
746746
`;
747747
748+
exports[`SFC compile <script setup> > dev mode import usage check > dynamic arguments 1`] = `
749+
"import { defineComponent as _defineComponent } from 'vue'
750+
import { FooBar, foo, bar, unused } from './x'
751+
752+
export default /*#__PURE__*/_defineComponent({
753+
setup(__props, { expose: __expose }) {
754+
__expose();
755+
756+
757+
return { get FooBar() { return FooBar }, get foo() { return foo }, get bar() { return bar } }
758+
}
759+
760+
})"
761+
`;
762+
748763
exports[`SFC compile <script setup> > dev mode import usage check > js template string interpolations 1`] = `
749764
"import { defineComponent as _defineComponent } from 'vue'
750765
import { VAR, VAR2, VAR3 } from './x'

packages/compiler-sfc/__tests__/compileScript.spec.ts

+19
Original file line numberDiff line numberDiff line change
@@ -413,6 +413,25 @@ describe('SFC compile <script setup>', () => {
413413
assertCode(content)
414414
})
415415

416+
test('dynamic arguments', () => {
417+
const { content } = compile(`
418+
<script setup lang="ts">
419+
import { FooBar, foo, bar, unused } from './x'
420+
</script>
421+
<template>
422+
<FooBar #[foo.slotName] />
423+
<FooBar #unused />
424+
<div :[bar.attrName]="15"></div>
425+
<div unused="unused"></div>
426+
</template>
427+
`)
428+
expect(content).toMatch(
429+
`return { get FooBar() { return FooBar }, get foo() { return foo }, ` +
430+
`get bar() { return bar } }`
431+
)
432+
assertCode(content)
433+
})
434+
416435
// https://github.com/vuejs/core/issues/4599
417436
test('attribute expressions', () => {
418437
const { content } = compile(`

packages/compiler-sfc/src/script/importUsageCheck.ts

+6
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,12 @@ function resolveTemplateUsageCheckString(sfc: SFCDescriptor) {
5050
if (!isBuiltInDirective(prop.name)) {
5151
code += `,v${capitalize(camelize(prop.name))}`
5252
}
53+
if (prop.arg && !(prop.arg as SimpleExpressionNode).isStatic) {
54+
code += `,${processExp(
55+
(prop.arg as SimpleExpressionNode).content,
56+
prop.name
57+
)}`
58+
}
5359
if (prop.exp) {
5460
code += `,${processExp(
5561
(prop.exp as SimpleExpressionNode).content,

0 commit comments

Comments
 (0)