Skip to content

Commit b51b79f

Browse files
committed
refactor: rename optimizeBindings -> optimizeImports
1 parent 5f27151 commit b51b79f

File tree

5 files changed

+14
-14
lines changed

5 files changed

+14
-14
lines changed

packages/compiler-core/__tests__/__snapshots__/codegen.spec.ts.snap

+1-1
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ export function render(_ctx, _cache) {
171171
}"
172172
`;
173173

174-
exports[`compiler: codegen module mode preamble w/ optimizeBindings: true 1`] = `
174+
exports[`compiler: codegen module mode preamble w/ optimizeImports: true 1`] = `
175175
"import { createVNode, resolveDirective } from \\"vue\\"
176176
177177
// Binding optimization for webpack code-split

packages/compiler-core/__tests__/codegen.spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,11 @@ describe('compiler: codegen', () => {
6868
expect(code).toMatchSnapshot()
6969
})
7070

71-
test('module mode preamble w/ optimizeBindings: true', () => {
71+
test('module mode preamble w/ optimizeImports: true', () => {
7272
const root = createRoot({
7373
helpers: [CREATE_VNODE, RESOLVE_DIRECTIVE]
7474
})
75-
const { code } = generate(root, { mode: 'module', optimizeBindings: true })
75+
const { code } = generate(root, { mode: 'module', optimizeImports: true })
7676
expect(code).toMatch(
7777
`import { ${helperNameMap[CREATE_VNODE]}, ${
7878
helperNameMap[RESOLVE_DIRECTIVE]

packages/compiler-core/src/codegen.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ function createCodegenContext(
8888
sourceMap = false,
8989
filename = `template.vue.html`,
9090
scopeId = null,
91-
optimizeBindings = false,
91+
optimizeImports = false,
9292
runtimeGlobalName = `Vue`,
9393
runtimeModuleName = `vue`,
9494
ssr = false
@@ -100,7 +100,7 @@ function createCodegenContext(
100100
sourceMap,
101101
filename,
102102
scopeId,
103-
optimizeBindings,
103+
optimizeImports,
104104
runtimeGlobalName,
105105
runtimeModuleName,
106106
ssr,
@@ -355,7 +355,7 @@ function genModulePreamble(
355355
helper,
356356
newline,
357357
scopeId,
358-
optimizeBindings,
358+
optimizeImports,
359359
runtimeModuleName
360360
} = context
361361

@@ -368,7 +368,7 @@ function genModulePreamble(
368368

369369
// generate import statements for helpers
370370
if (ast.helpers.length) {
371-
if (optimizeBindings) {
371+
if (optimizeImports) {
372372
// when bundled with webpack with code-split, calling an import binding
373373
// as a function leads to it being wrapped with `Object(a.b)` or `(0,a.b)`,
374374
// incurring both payload size increase and potential perf overhead.

packages/compiler-core/src/options.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ export interface CodegenOptions {
155155
* (only used for webpack code-split)
156156
* @default false
157157
*/
158-
optimizeBindings?: boolean
158+
optimizeImports?: boolean
159159
/**
160160
* Customize where to import runtime helpers from.
161161
* @default 'vue'

packages/template-explorer/src/options.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export const ssrMode = ref(false)
66
export const compilerOptions: CompilerOptions = reactive({
77
mode: 'module',
88
prefixIdentifiers: false,
9-
optimizeBindings: false,
9+
optimizeImports: false,
1010
hoistStatic: false,
1111
cacheHandlers: false,
1212
scopeId: null
@@ -144,18 +144,18 @@ const App = {
144144
h('label', { for: 'scope-id' }, 'scopeId')
145145
]),
146146

147-
// toggle optimizeBindings
147+
// toggle optimizeImports
148148
h('li', [
149149
h('input', {
150150
type: 'checkbox',
151-
id: 'optimize-bindings',
151+
id: 'optimize-imports',
152152
disabled: !isModule || isSSR,
153-
checked: isModule && !isSSR && compilerOptions.optimizeBindings,
153+
checked: isModule && !isSSR && compilerOptions.optimizeImports,
154154
onChange(e: Event) {
155-
compilerOptions.optimizeBindings = (e.target as HTMLInputElement).checked
155+
compilerOptions.optimizeImports = (e.target as HTMLInputElement).checked
156156
}
157157
}),
158-
h('label', { for: 'optimize-bindings' }, 'optimizeBindings')
158+
h('label', { for: 'optimize-imports' }, 'optimizeImports')
159159
])
160160
])
161161
])

0 commit comments

Comments
 (0)