fix(reactivity): effect should still check sync self-trigger

yyx990803 · yyx990803 · commit ac81dcf0cc7f · 2020-08-13T17:45:21.000-04:00
diff --git a/packages/reactivity/src/effect.ts b/packages/reactivity/src/effect.ts
@@ -178,7 +178,11 @@ export function trigger(
   const effects = new Set<ReactiveEffect>()
   const add = (effectsToAdd: Set<ReactiveEffect> | undefined) => {
     if (effectsToAdd) {
-      effectsToAdd.forEach(effect => effects.add(effect))
+      effectsToAdd.forEach(effect => {
+        if (effect !== activeEffect) {
+          effects.add(effect)
+        }
+      })
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,11 @@ export function trigger(`
`178`	`178`	`const effects = new Set<ReactiveEffect>()`
`179`	`179`	`const add = (effectsToAdd: Set<ReactiveEffect> \| undefined) => {`
`180`	`180`	`if (effectsToAdd) {`
`181`		`- effectsToAdd.forEach(effect => effects.add(effect))`
	`181`	`+ effectsToAdd.forEach(effect => {`
	`182`	`+ if (effect !== activeEffect) {`
	`183`	`+ effects.add(effect)`
	`184`	`+ }`
	`185`	`+ })`
`182`	`186`	`}`
`183`	`187`	`}`
`184`	`188`