fix(devtools): make el extra properties non-enumerable

Akryum · Akryum · commit 7fd3436290f3 · 2020-08-29T05:00:38.000+02:00
diff --git a/packages/runtime-core/src/renderer.ts b/packages/runtime-core/src/renderer.ts
@@ -756,8 +756,14 @@ function baseCreateRenderer(
       }
     }
     if (__DEV__ || __FEATURE_PROD_DEVTOOLS__) {
-      el.__vnode = vnode
-      el.__vueParentComponent = parentComponent
+      Object.defineProperty(el, '__vnode', {
+        value: vnode,
+        enumerable: false
+      })
+      Object.defineProperty(el, '__vueParentComponent', {
+        value: parentComponent,
+        enumerable: false
+      })
     }
     if (dirs) {
       invokeDirectiveHook(vnode, null, parentComponent, 'beforeMount')

Original file line number	Diff line number	Diff line change
`@@ -756,8 +756,14 @@ function baseCreateRenderer(`
`756`	`756`	`}`
`757`	`757`	`}`
`758`	`758`	`if (__DEV__ \|\| __FEATURE_PROD_DEVTOOLS__) {`
`759`		`- el.__vnode = vnode`
`760`		`- el.__vueParentComponent = parentComponent`
	`759`	`+ Object.defineProperty(el, '__vnode', {`
	`760`	`+ value: vnode,`
	`761`	`+ enumerable: false`
	`762`	`+ })`
	`763`	`+ Object.defineProperty(el, '__vueParentComponent', {`
	`764`	`+ value: parentComponent,`
	`765`	`+ enumerable: false`
	`766`	`+ })`
`761`	`767`	`}`
`762`	`768`	`if (dirs) {`
`763`	`769`	`invokeDirectiveHook(vnode, null, parentComponent, 'beforeMount')`