Skip to content

Commit 730e39e

Browse files
committed
refactor: remove unnecessary conditions and test case
1 parent b7ef38b commit 730e39e

File tree

2 files changed

+2
-21
lines changed

2 files changed

+2
-21
lines changed

packages/reactivity/__tests__/effect.spec.ts

+1-12
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ import {
66
TrackOpTypes,
77
TriggerOpTypes,
88
DebuggerEvent,
9-
markRaw,
10-
ref
9+
markRaw
1110
} from '../src/index'
1211
import { ITERATE_KEY } from '../src/effect'
1312

@@ -782,14 +781,4 @@ describe('reactivity/effect', () => {
782781
expect(dummy).toBe(0)
783782
expect(record).toBeUndefined()
784783
})
785-
786-
it('should handle self dependency mutations', () => {
787-
const count = ref(0)
788-
effect(() => {
789-
count.value++
790-
})
791-
expect(count.value).toBe(1)
792-
count.value = 10
793-
expect(count.value).toBe(11)
794-
})
795784
})

packages/reactivity/src/effect.ts

+1-9
Original file line numberDiff line numberDiff line change
@@ -178,15 +178,7 @@ export function trigger(
178178
const effects = new Set<ReactiveEffect>()
179179
const add = (effectsToAdd: Set<ReactiveEffect> | undefined) => {
180180
if (effectsToAdd) {
181-
effectsToAdd.forEach(effect => {
182-
if (effect !== activeEffect || !shouldTrack) {
183-
effects.add(effect)
184-
} else {
185-
// the effect mutated its own dependency during its execution.
186-
// this can be caused by operations like foo.value++
187-
// do not trigger or we end in an infinite loop
188-
}
189-
})
181+
effectsToAdd.forEach(effect => effects.add(effect))
190182
}
191183
}
192184

0 commit comments

Comments
 (0)