Skip to content

Commit 69b74a8

Browse files
authored
chore(puppeteer): upgrade puppeteer (#4019)
* chore(puppeteer): upgrade puppeteer * fix(tests): fix typescript error with puppeteer 5.X types Co-authored-by: bas <[email protected]>
1 parent 489db4f commit 69b74a8

File tree

8 files changed

+173
-92
lines changed

8 files changed

+173
-92
lines changed

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
"@types/hash-sum": "^1.0.0",
5353
"@types/jest": "^26.0.16",
5454
"@types/node": "^14.10.1",
55-
"@types/puppeteer": "^2.0.0",
55+
"@types/puppeteer": "^5.0.0",
5656
"@typescript-eslint/parser": "^4.1.1",
5757
"brotli": "^1.3.2",
5858
"chalk": "^4.1.0",
@@ -67,7 +67,7 @@
6767
"minimist": "^1.2.0",
6868
"npm-run-all": "^4.1.5",
6969
"prettier": "~1.14.0",
70-
"puppeteer": "^2.0.0",
70+
"puppeteer": "^10.0.0",
7171
"rollup": "~2.38.5",
7272
"rollup-plugin-node-builtins": "^2.1.2",
7373
"rollup-plugin-node-globals": "^1.4.0",

packages/vue/__tests__/Transition.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ describe('e2e: Transition', () => {
2929

3030
beforeEach(async () => {
3131
await page().goto(baseUrl)
32-
await page().waitFor('#app')
32+
await page().waitForSelector('#app')
3333
})
3434

3535
describe('transition with v-if', () => {

packages/vue/__tests__/TransitionGroup.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ describe('e2e: TransitionGroup', () => {
2121

2222
beforeEach(async () => {
2323
await page().goto(baseUrl)
24-
await page().waitFor('#app')
24+
await page().waitForSelector('#app')
2525
})
2626

2727
test(

packages/vue/__tests__/e2eUtils.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ export function setupPuppeteer() {
108108
await page.$eval(
109109
selector,
110110
(node, value) => {
111-
;(node as HTMLInputElement).value = value
111+
;(node as HTMLInputElement).value = value as string
112112
node.dispatchEvent(new Event('input'))
113113
},
114114
value

packages/vue/examples/__tests__/commits.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ describe('e2e: commits', () => {
2828
})
2929

3030
await page().goto(baseUrl)
31-
await page().waitFor('li')
31+
await page().waitForSelector('li')
3232
expect(await count('input')).toBe(2)
3333
expect(await count('label')).toBe(2)
3434
expect(await text('label[for="master"]')).toBe('master')

packages/vue/examples/__tests__/grid.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ describe('e2e: grid', () => {
2828
)}`
2929

3030
await page().goto(baseUrl)
31-
await page().waitFor('table')
31+
await page().waitForSelector('table')
3232
expect(await count('th')).toBe(2)
3333
expect(await count('th.active')).toBe(0)
3434
expect(await text('th:nth-child(1)')).toContain('Name')

packages/vue/examples/__tests__/svg.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ describe('e2e: svg', () => {
7777
)}`
7878

7979
await page().goto(baseUrl)
80-
await page().waitFor('svg')
80+
await page().waitForSelector('svg')
8181
expect(await count('g')).toBe(1)
8282
expect(await count('polygon')).toBe(1)
8383
expect(await count('circle')).toBe(1)

yarn.lock

+165-84
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)