Skip to content

Commit 3fafc3b

Browse files
yyx990803pikax
andauthored
types(runtime-core): improve types for transition hook (#1009)
* types(runtime-core): improve types for transition hook fix #1000 * Update packages/runtime-core/src/components/BaseTransition.ts Co-Authored-By: Carlos Rodrigues <[email protected]> * fix: run ci Co-authored-by: Carlos Rodrigues <[email protected]>
2 parents 419b86d + 6b889e7 commit 3fafc3b

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

packages/runtime-core/src/components/BaseTransition.ts

+9-9
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,14 @@ export interface BaseTransitionProps<HostElement = RendererElement> {
4343
onLeaveCancelled?: (el: HostElement) => void // only fired in persisted mode
4444
}
4545

46-
export interface TransitionHooks {
46+
export interface TransitionHooks<HostElement extends RendererElement = RendererElement> {
4747
persisted: boolean
48-
beforeEnter(el: RendererElement): void
49-
enter(el: RendererElement): void
50-
leave(el: RendererElement, remove: () => void): void
48+
beforeEnter(el: HostElement): void
49+
enter(el: HostElement): void
50+
leave(el: HostElement, remove: () => void): void
5151
afterLeave?(): void
5252
delayLeave?(
53-
el: RendererElement,
53+
el: HostElement,
5454
earlyRemove: () => void,
5555
delayedLeave: () => void
5656
): void
@@ -272,9 +272,9 @@ export function resolveTransitionHooks(
272272
)
273273
}
274274

275-
const hooks: TransitionHooks = {
275+
const hooks: TransitionHooks<TransitionElement> = {
276276
persisted,
277-
beforeEnter(el: TransitionElement) {
277+
beforeEnter(el) {
278278
if (!appear && !state.isMounted) {
279279
return
280280
}
@@ -295,7 +295,7 @@ export function resolveTransitionHooks(
295295
callHook(onBeforeEnter, [el])
296296
},
297297

298-
enter(el: TransitionElement) {
298+
enter(el) {
299299
if (!appear && !state.isMounted) {
300300
return
301301
}
@@ -320,7 +320,7 @@ export function resolveTransitionHooks(
320320
}
321321
},
322322

323-
leave(el: TransitionElement, remove) {
323+
leave(el, remove) {
324324
const key = String(vnode.key)
325325
if (el._enterCb) {
326326
el._enterCb(true /* cancelled */)

packages/runtime-core/src/vnode.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ export interface VNode<HostNode = RendererNode, HostElement = RendererElement> {
120120
component: ComponentInternalInstance | null
121121
suspense: SuspenseBoundary | null
122122
dirs: DirectiveBinding[] | null
123-
transition: TransitionHooks | null
123+
transition: TransitionHooks<HostElement> | null
124124

125125
// DOM
126126
el: HostNode | null

0 commit comments

Comments
 (0)