Skip to content

Commit 3a6f5eb

Browse files
committed
fix(build): ensure BaseTransition functions can be tree-shaken
1 parent a5dcbad commit 3a6f5eb

File tree

3 files changed

+26
-22
lines changed

3 files changed

+26
-22
lines changed

packages/runtime-core/src/components/BaseTransition.ts

+22-20
Original file line numberDiff line numberDiff line change
@@ -111,29 +111,31 @@ export function useTransitionState(): TransitionState {
111111

112112
const TransitionHookValidator = [Function, Array]
113113

114+
export const BaseTransitionPropsValidators = {
115+
mode: String,
116+
appear: Boolean,
117+
persisted: Boolean,
118+
// enter
119+
onBeforeEnter: TransitionHookValidator,
120+
onEnter: TransitionHookValidator,
121+
onAfterEnter: TransitionHookValidator,
122+
onEnterCancelled: TransitionHookValidator,
123+
// leave
124+
onBeforeLeave: TransitionHookValidator,
125+
onLeave: TransitionHookValidator,
126+
onAfterLeave: TransitionHookValidator,
127+
onLeaveCancelled: TransitionHookValidator,
128+
// appear
129+
onBeforeAppear: TransitionHookValidator,
130+
onAppear: TransitionHookValidator,
131+
onAfterAppear: TransitionHookValidator,
132+
onAppearCancelled: TransitionHookValidator
133+
}
134+
114135
const BaseTransitionImpl: ComponentOptions = {
115136
name: `BaseTransition`,
116137

117-
props: {
118-
mode: String,
119-
appear: Boolean,
120-
persisted: Boolean,
121-
// enter
122-
onBeforeEnter: TransitionHookValidator,
123-
onEnter: TransitionHookValidator,
124-
onAfterEnter: TransitionHookValidator,
125-
onEnterCancelled: TransitionHookValidator,
126-
// leave
127-
onBeforeLeave: TransitionHookValidator,
128-
onLeave: TransitionHookValidator,
129-
onAfterLeave: TransitionHookValidator,
130-
onLeaveCancelled: TransitionHookValidator,
131-
// appear
132-
onBeforeAppear: TransitionHookValidator,
133-
onAppear: TransitionHookValidator,
134-
onAfterAppear: TransitionHookValidator,
135-
onAppearCancelled: TransitionHookValidator
136-
},
138+
props: BaseTransitionPropsValidators,
137139

138140
setup(props: BaseTransitionProps, { slots }: SetupContext) {
139141
const instance = getCurrentInstance()!

packages/runtime-core/src/index.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,8 @@ export { Suspense, SuspenseProps } from './components/Suspense'
9393
export { KeepAlive, KeepAliveProps } from './components/KeepAlive'
9494
export {
9595
BaseTransition,
96-
BaseTransitionProps
96+
BaseTransitionPropsValidators,
97+
type BaseTransitionProps
9798
} from './components/BaseTransition'
9899
// For using custom directives
99100
export { withDirectives } from './directives'

packages/runtime-dom/src/components/Transition.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import {
22
BaseTransition,
33
BaseTransitionProps,
4+
BaseTransitionPropsValidators,
45
h,
56
assertNumber,
67
FunctionalComponent,
@@ -74,7 +75,7 @@ const DOMTransitionPropsValidators = {
7475
export const TransitionPropsValidators = (Transition.props =
7576
/*#__PURE__*/ extend(
7677
{},
77-
(BaseTransition as any).props,
78+
BaseTransitionPropsValidators as any,
7879
DOMTransitionPropsValidators
7980
))
8081

0 commit comments

Comments
 (0)