fix(TransitionGroup): ignore comment node when warn (fix#869) (#875)

ysj16 · web-flow · commit 0dba5d44e60d · 2020-03-24T12:09:42.000-04:00
diff --git a/packages/runtime-dom/src/components/TransitionGroup.ts b/packages/runtime-dom/src/components/TransitionGroup.ts
@@ -9,6 +9,7 @@ import {
 } from './Transition'
 import {
   Fragment,
+  Comment,
   VNode,
   warn,
   resolveTransitionHooks,
@@ -108,7 +109,7 @@ const TransitionGroupImpl = {
             child,
             resolveTransitionHooks(child, cssTransitionProps, state, instance)
           )
-        } else if (__DEV__) {
+        } else if (__DEV__ && child.type !== Comment) {
           warn(`<TransitionGroup> children must be keyed.`)
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ import {`
`9`	`9`	`} from './Transition'`
`10`	`10`	`import {`
`11`	`11`	`Fragment,`
	`12`	`+ Comment,`
`12`	`13`	`VNode,`
`13`	`14`	`warn,`
`14`	`15`	`resolveTransitionHooks,`
`@@ -108,7 +109,7 @@ const TransitionGroupImpl = {`
`108`	`109`	`child,`
`109`	`110`	`resolveTransitionHooks(child, cssTransitionProps, state, instance)`
`110`	`111`	`)`
`111`		`- } else if (__DEV__) {`
	`112`	`+ } else if (__DEV__ && child.type !== Comment) {`
`112`	`113`	warn(`<TransitionGroup> children must be keyed.`)
`113`	`114`	`}`
`114`	`115`	`}`