Skip to content

Commit 0d61b42

Browse files
fix(types): add xmlns:xlink to SVGAttributes (#9300)
close #9299
1 parent b1fe48d commit 0d61b42

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

packages/dts-test/tsx.test-d.tsx

+8
Original file line numberDiff line numberDiff line change
@@ -112,3 +112,11 @@ expectType<JSX.Element>(
112112
)
113113
// @ts-expect-error
114114
;<Suspense onResolve={123} />
115+
116+
// svg
117+
expectType<JSX.Element>(
118+
<svg
119+
xmlnsXlink="http://www.w3.org/1999/xlink"
120+
xmlns="http://www.w3.org/2000/svg"
121+
/>
122+
)

packages/runtime-dom/src/jsx.ts

+1
Original file line numberDiff line numberDiff line change
@@ -1077,6 +1077,7 @@ export interface SVGAttributes extends AriaAttributes, EventHandlers<Events> {
10771077
xlinkTitle?: string
10781078
xlinkType?: string
10791079
xmlns?: string
1080+
xmlnsXlink?: string
10801081
y1?: Numberish
10811082
y2?: Numberish
10821083
y?: Numberish

packages/shared/src/domAttrConfig.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,6 @@ export const isKnownSvgAttr = /*#__PURE__*/ makeMap(
118118
`v-mathematical,values,vector-effect,version,vert-adv-y,vert-origin-x,` +
119119
`vert-origin-y,viewBox,viewTarget,visibility,width,widths,word-spacing,` +
120120
`writing-mode,x,x-height,x1,x2,xChannelSelector,xlink:actuate,xlink:arcrole,` +
121-
`xlink:href,xlink:role,xlink:show,xlink:title,xlink:type,xml:base,xml:lang,` +
121+
`xlink:href,xlink:role,xlink:show,xlink:title,xlink:type,xmlns:xlink,xml:base,xml:lang,` +
122122
`xml:space,y,y1,y2,yChannelSelector,z,zoomAndPan`
123123
)

0 commit comments

Comments
 (0)