chore: better warning when remounting a mounted app (#1297)

underfin · web-flow · commit 0b934401469c · 2020-06-11T17:20:38.000-04:00
diff --git a/packages/runtime-core/src/apiCreateApp.ts b/packages/runtime-core/src/apiCreateApp.ts
@@ -225,7 +225,10 @@ export function createAppAPI<HostElement>(
           return vnode.component!.proxy
         } else if (__DEV__) {
           warn(
-            `App has already been mounted. Create a new app instance instead.`
+            `App has already been mounted.\n` +
+              `If you want to remount the same app, move your app creation logic ` +
+              `into a factory function and create fresh app instances for each ` +
+              `mount - e.g. \`const createMyApp = () => createApp(App)\``
           )
         }
       },

Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,10 @@ export function createAppAPI<HostElement>(`
`225`	`225`	`return vnode.component!.proxy`
`226`	`226`	`} else if (__DEV__) {`
`227`	`227`	`warn(`
`228`		- `App has already been mounted. Create a new app instance instead.`
	`228`	+ `App has already been mounted.\n` +
	`229`	+ `If you want to remount the same app, move your app creation logic ` +
	`230`	+ `into a factory function and create fresh app instances for each ` +
	`231`	+ `mount - e.g. \`const createMyApp = () => createApp(App)\``
`229`	`232`	`)`
`230`	`233`	`}`
`231`	`234`	`},`