fix(transfer): checkbox click evt run repeatedly #6903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangjinzhou
requested changes
Aug 30, 2023
components/transfer/style/index.less
Outdated
| line-height: 1; | ||
| align-items: center; | ||
|
|
||
| .ant-checkbox { |
There was a problem hiding this comment.
因为好像那里用的是组件，然后有个 top 属性，我只能这样重置了。
There was a problem hiding this comment.
4.x 那个应该是没问题的，我给 antd 也提了 pr，合了
There was a problem hiding this comment.
<li
...
>
<Checkbox
class={`${prefixCls}-checkbox`}
checked={checked}
disabled={disabled || item.disabled}
/>
{labelNode}
</li>他这里是这样，然后是因为 checkbox 组件里面的一个 span 的样式有 top: 0.2em 属性，就会导致下面这样
& > span {
top: 0;
}不写死 .ant 前缀的话，像这样吗？感觉没啥区别
There was a problem hiding this comment.
ant 这个用户可以自定义的，用户如果改成abc，你给写死了不就不生效了
There was a problem hiding this comment.
& > span {
top: 0;
}那就这样？
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #6010