Antd typescript support #359
Conversation
Added typing files for better support in Typescript
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
==========================================
+ Coverage 87% 87.02% +0.02%
==========================================
Files 143 143
Lines 4556 4556
Branches 1329 1329
==========================================
+ Hits 3964 3965 +1
+ Misses 558 557 -1
Partials 34 34
Continue to review full report at Codecov.
|
Adding declare keywords left in last commit
Added support to add Ant Design globally (Vue.use(Antd))
Fix wrong import file
types/tree-select.d.ts
Outdated
| * Data of the treeNodes, manual construction work is no longer needed | ||
| * if this property has been set(ensure the Uniqueness of each value) | ||
| * @default [] | ||
| * @type aobject[] |
There was a problem hiding this comment.
@wangxueliang quick to find mistake 😜
changed aobject[] to object[]
types/auto-complete.d.ts
Outdated
|
|
||
| /** | ||
| * Data source for autocomplete | ||
| * @type slot | { value: String, text: String } |
There was a problem hiding this comment.
- @type slot | Array<{ value: String, text: String }> ?
types/date-picker/range-picker.ts
Outdated
| * to set default picker date | ||
| * @type Moment | ||
| */ | ||
| defaultPickerValue: Moment; |
There was a problem hiding this comment.
defaultPickerValue: [Moment, Moment];
Sorry, the document has an error
types/date-picker/range-picker.ts
Outdated
| * to set date | ||
| * @type Moment | ||
| */ | ||
| value: Moment; |
types/dropdown/dropdown-button.d.ts
Outdated
| * @default 'bottomLeft' | ||
| * @type string | ||
| */ | ||
| plcement: string; |
| top?: string; | ||
| } | ||
|
|
||
| export declare class Message { |
types/pagination.d.ts
Outdated
| * @default false | ||
| * @type boolean | ||
| */ | ||
| showSizeChanger: Boolean; |
types/radio/radio-button.d.ts
Outdated
| * Type of radio button | ||
| * @type string | ||
| */ | ||
| type: String; |
There was a problem hiding this comment.
I am not sure to support capitalization.
types/table/table.d.ts
Outdated
| * Set props on per header row | ||
| * @type Function | ||
| */ | ||
| customHeaderRow: (column: any, index: number) => any; |
There was a problem hiding this comment.
Many users have questions about customXXX, maybe we can give more detailed types instead of any.
There was a problem hiding this comment.
@tangjinzhou Yes we can, but it is very hard to find type for customXXX. So, can we discuss about this?
And all other changes are done.
There was a problem hiding this comment.
https://github.com/vuejs/babel-plugin-transform-vue-jsx#difference-from-react-jsx
{
props, attrs, on, class, style, nativeOn,
}
There was a problem hiding this comment.
is this return type applicable on all customXXX (customRow customHeaderRow customCell customHeaderCel)?l
types/transfer.d.ts
Outdated
| * @default [] | ||
| * @type TransferItem | ||
| */ | ||
| dataSource: TransferItem; |
types/tree-node.d.ts
Outdated
| * @default internal calculated position of treeNode or undefined | ||
| * @type string | ||
| */ | ||
| key: string; |
types/tree-select.d.ts
Outdated
| import { TreeNode } from './tree-node'; | ||
|
|
||
| export interface TreeData { | ||
| key: string; |
| selectable?: boolean; | ||
| } | ||
|
|
||
| export declare class TreeSelect extends AntdComponent { |
There was a problem hiding this comment.
add new prop treeExpandedKeys in v1.2.3
types/tree/dictionary-tree.d.ts
Outdated
|
|
||
| import { AntdComponent } from "../component"; | ||
|
|
||
| export declare class DictionaryTree extends AntdComponent { |
types/tree/tree.d.ts
Outdated
| * @default [] | ||
| * @type string[] | { checked: string[]; halfChecked: string[] } | ||
| */ | ||
| checkedKeys: string[] | { checked: string[]; halfChecked: string[] }; |
There was a problem hiding this comment.
Tree and TreeSelect : xxxKeys should support number[]
new feature at 1.2.3
types/affix.d.ts
Outdated
| @@ -0,0 +1,28 @@ | |||
| // Type definitions for Ant Design Vue 1.2.2 | |||
There was a problem hiding this comment.
I think we don't need to add version information.
Removed Library version from comments & corrected few incorrect types
Tree : xxxKeys should support number[]
types/dropdown/dropdown-button.d.ts
Outdated
| @@ -24,7 +23,13 @@ export declare class DropdownButton extends AntdComponent { | |||
| * @default 'bottomLeft' | |||
| * @type string | |||
| */ | |||
| plcement: string; | |||
| plcement: | |||
There was a problem hiding this comment.
Is here something wrong?
types/table/table.d.ts
Outdated
| * Set props on per header row | ||
| * @type Function | ||
| */ | ||
| customHeaderRow: (column: any, index: number) => any; |
There was a problem hiding this comment.
https://github.com/vuejs/babel-plugin-transform-vue-jsx#difference-from-react-jsx
{
props, attrs, on, class, style, nativeOn,
}
table: updated return type for customXXX
Fix spelling mistake (plcement => placement)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
for more info look #250