Skip to content

fix: remove redundant tabindex on autocomplete #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

haivp3010
Copy link

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
    Currently the autocomplete component has a redundant tab index on the wrapper element, causing 2 tabs to get into the actual input child element.
  2. Resolve what problem.
    The redundant tab index should be removed, so the autocomplete input's tab index works consistently like other input.
  3. Related issue link.
    autocomplete gets focus on second tab key #1438

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
    Yes. The way focus works on the autocomplete component will be corrected, requiring only one Tab keypress to get to like any other input.
  2. What will say in changelog?
    Fix redundant tabindex on the wrapper element of autocomplete
  3. Does this PR contains potential break change or other risk?
    No

Changelog description (Optional if not new feature)

  1. English description
    Fix redundant tabindex on the wrapper element of autocomplete
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@tangjinzhou
Copy link
Member

thank you for your contribution!
I commited a more general plan. 5597ec0

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants