Skip to content

feat: Vue 3 Migration Build support #5973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

garretmh
Copy link
Contributor

@garretmh garretmh commented Sep 19, 2022

closes #5765

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

Backwards-compatibility features in Vue 3 Migration Build conflict with ant-design-vue.
Example: #5765

API Realization (Optional if not new feature)

Adding compatConfig: { MODE: 3 } to component definitions signals to @vue/compat that none of these components rely on any Vue 2 features.

What's the effect? (Optional if not new feature)

The compatConfig component option is only used by @vue/compat to enable/disable compatibility features within the individual components.

Changelog description (Optional if not new feature)

  1. English description
    Add compatConfig: { MODE: 3 } to all component definitions to signal to @vue/compat not to use any Vue 2 compatibility features.
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

closes vueComponent#5765

Add `compatConfig: { MODE: 3 }` to all component definitions to signal to `@vue/compat` not to use any Vue 2 compatibility features.
@tangjinzhou tangjinzhou merged commit a2f7d6d into vueComponent:main Sep 26, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@vue/compat error with Cannot read properties of undefined (reading 'getPrefixCls')
2 participants