-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Unclear documentation of slider component: dots, included, marks vs. ticks missing fail-safe for incorrect usage results in problematic script execution #1765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Two more notes:
|
Relatedly, the following warning:
which gets output to the dev console as a result of me using |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Well, if these problems haven't been fixed yet, they still need fixing. |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Version
1.4.10
Environment
Linux, FF 68.4.1esr, Vue 2.6.10
Reproduction link
Steps to reproduce
scenario A)
include
:dots='true'
in existing slider where:step='n'
(where n is a number value > 0)scenario B)
include
:dots='true'
in existing slider where:step='null'
What is expected?
scenario A)
according to the documentation,
dots
decide "Whether the thumb can drag over tick only." – to me this translates to:dots
won't let the user drop the active slider demarcation randomly, but only on pre-defined markers of segments (confusingly sometimes referred to as ticks, sometimes as marks)scenario B)
the same as above, because the documentation does not warn against using
dots
with:step='null'
What is actually happening?
scenario A)
circle marks appear on the slider at every mark (or step), but the behaviour of the slider does not change as advertised. In fact, when steps are defined (given a positive value), the user can only ever drag and drop the slider onto a "step mark" anyway (even if it's invisible), regardless of if there are dots or not.
scenario B)
the script slows down the browser to a point it prompts the user to halt the script or continue waiting; on checking the dev console, it appears a warning regarding
dots
and:step='null'
is logged to the console, but no fail-safe is built into the scriptPlease add a third category for issues having to do with documentation to your ticket types dropdown.
It's awkward to be greeted by a message saying normal GitHub issues will be ignored and to then have to fill out a bug report and provide a minimal reproduction for issues which aren't bugs but can be attributed to incomplete documentation or imprecise wording / translation (scenario A).
The text was updated successfully, but these errors were encountered: