Skip to content

Hook event listener firing twice #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
ankology opened this issue Feb 3, 2020 · 3 comments
Closed
1 task done

Hook event listener firing twice #1756

ankology opened this issue Feb 3, 2020 · 3 comments

Comments

@ankology
Copy link

ankology commented Feb 3, 2020

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

1.4.10

Environment

Mapped in reproduction

Reproduction link

Edit on CodeSandbox

Explanation

Just look at console, the hook will be fired twice. Looking the code from "a-switch" is passed down the $listeners, and because of that its fired twice, i think this happen in all the components that pass down $listeners, the "a-input" is not passing down nothing and works fine by example. In fact its not a really bug but looking at the point of view of a hook listener its correct to pass down the hook listeners along the first component? Thanks!

@tangjinzhou
Copy link
Member

20ff341
594dc07

fixed

@ankology
Copy link
Author

ankology commented Feb 6, 2020

That's it. Thank you!

@github-actions
Copy link

github-actions bot commented Feb 7, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants