Skip to content

TimePicker inner input has empty "id" attribute which trigger chrome "non-unique id" warrning #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
ycycorona opened this issue Dec 17, 2019 · 5 comments
Closed
1 task done

TimePicker inner input has empty "id" attribute which trigger chrome "non-unique id" warrning #1565

ycycorona opened this issue Dec 17, 2019 · 5 comments
Labels
outdated Stale

Comments

@ycycorona
Copy link

ycycorona commented Dec 17, 2019 •
edited
Loading

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

1.4.10

Environment

Chrome stable v79.0.3945.79

Reproduction link

Edit on CodeSandbox

Steps to reproduce

just add one more TimePicker component,and then check it out in the chrome console

What is expected?

TimePicker component shoudn't have empty "id" attribute

What is actually happening?

TimePicker inner input has empty "id" attribute which trigger chrome "non-unique id" warrning
@ycycorona ycycorona changed the title DatePicker inner input has empty "id" attribute which trigger chrome "non-unique id" warrning DatePicker/TimePicker inner input has empty "id" attribute which trigger chrome "non-unique id" warrning Dec 17, 2019
@zkwolf
Copy link
Member

zkwolf commented Dec 17, 2019

复现了一下，只有timepicker有吧

@ycycorona
Copy link
Author

复现了一下，只有timepicker有吧

那我改一下

@ycycorona ycycorona changed the title DatePicker/TimePicker inner input has empty "id" attribute which trigger chrome "non-unique id" warrning TimePicker inner input has empty "id" attribute which trigger chrome "non-unique id" warrning Dec 17, 2019
@zkwolf zkwolf mentioned this issue Dec 17, 2019
Merged
13 tasks
@shahiparwan
Copy link

supper but one tag is wrong so cheek your work

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jan 8, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zkwolf @ycycorona @shahiparwan