Skip to content

Commit afc1b84

Browse files
feat: ✨checkbox label slot support use option label (#6642)
* docs: 📃change the default setting of "treeNodeFilterProp" from "value" to "label" * revert: ↩revert this config and create another pr to commit * feat: ✨checkbox label slot support use option label * test: 🧪update checkbox *.snap file --------- Co-authored-by: tangjinzhou <[email protected]>
1 parent 58f6d6e commit afc1b84

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

components/checkbox/Group.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ export default defineComponent({
108108
onChange={option.onChange}
109109
class={`${groupPrefixCls.value}-item`}
110110
>
111-
{option.label === undefined ? slots.label?.(option) : option.label}
111+
{slots.label !== undefined ? slots.label?.(option) : option.label}
112112
</Checkbox>
113113
));
114114
}

components/checkbox/__tests__/__snapshots__/demo.test.js.snap

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ exports[`renders ./components/checkbox/demo/group.vue correctly 1`] = `
3939
<div class="ant-checkbox-group"><label class="ant-checkbox-wrapper ant-checkbox-group-item"><span class="ant-checkbox"><input type="checkbox" class="ant-checkbox-input" value="Apple"><span class="ant-checkbox-inner"></span></span><span>Apple</span></label><label class="ant-checkbox-wrapper ant-checkbox-wrapper-checked ant-checkbox-group-item"><span class="ant-checkbox ant-checkbox-checked"><input type="checkbox" class="ant-checkbox-input" value="Pear"><span class="ant-checkbox-inner"></span></span><span>Pear</span></label><label class="ant-checkbox-wrapper ant-checkbox-group-item"><span class="ant-checkbox"><input type="checkbox" class="ant-checkbox-input" value="Orange"><span class="ant-checkbox-inner"></span></span><span>Orange</span></label></div>
4040
<br>
4141
<br>
42-
<div class="ant-checkbox-group"><label class="ant-checkbox-wrapper ant-checkbox-wrapper-checked ant-checkbox-wrapper-disabled ant-checkbox-group-item"><span class="ant-checkbox ant-checkbox-checked ant-checkbox-disabled"><input type="checkbox" disabled="" class="ant-checkbox-input" value="Apple"><span class="ant-checkbox-inner"></span></span><span><span style="color: red;">Apple</span></span></label><label class="ant-checkbox-wrapper ant-checkbox-wrapper-disabled ant-checkbox-group-item"><span class="ant-checkbox ant-checkbox-disabled"><input type="checkbox" disabled="" class="ant-checkbox-input" value="Pear"><span class="ant-checkbox-inner"></span></span><span>Pear</span></label><label class="ant-checkbox-wrapper ant-checkbox-wrapper-disabled ant-checkbox-group-item"><span class="ant-checkbox ant-checkbox-disabled"><input type="checkbox" disabled="" class="ant-checkbox-input" value="Orange"><span class="ant-checkbox-inner"></span></span><span>Orange</span></label></div>
42+
<div class="ant-checkbox-group"><label class="ant-checkbox-wrapper ant-checkbox-wrapper-checked ant-checkbox-wrapper-disabled ant-checkbox-group-item"><span class="ant-checkbox ant-checkbox-checked ant-checkbox-disabled"><input type="checkbox" disabled="" class="ant-checkbox-input" value="Apple"><span class="ant-checkbox-inner"></span></span><span><span style="color: red;">Apple</span></span></label><label class="ant-checkbox-wrapper ant-checkbox-wrapper-disabled ant-checkbox-group-item"><span class="ant-checkbox ant-checkbox-disabled"><input type="checkbox" disabled="" class="ant-checkbox-input" value="Pear"><span class="ant-checkbox-inner"></span></span><span><span style="color: red;">Pear</span></span></label><label class="ant-checkbox-wrapper ant-checkbox-wrapper-disabled ant-checkbox-group-item"><span class="ant-checkbox ant-checkbox-disabled"><input type="checkbox" disabled="" class="ant-checkbox-input" value="Orange"><span class="ant-checkbox-inner"></span></span><span><span style="color: red;">Orange</span></span></label></div>
4343
`;
4444
4545
exports[`renders ./components/checkbox/demo/layout.vue correctly 1`] = `

components/checkbox/demo/group.vue

+3-3
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ Generate a group of checkboxes from an array
2727
<br />
2828
<br />
2929
<a-checkbox-group v-model:value="state.value4" :options="optionsWithDisabled" disabled>
30-
<template #label="{ value }">
31-
<span style="color: red">{{ value }}</span>
30+
<template #label="{ label }">
31+
<span style="color: red">{{ label }}</span>
3232
</template>
3333
</a-checkbox-group>
3434
</template>
@@ -42,7 +42,7 @@ const options = [
4242
{ label: 'Orange', value: 'Orange' },
4343
];
4444
const optionsWithDisabled = [
45-
{ value: 'Apple' },
45+
{ label: 'Apple', value: 'Apple' },
4646
{ label: 'Pear', value: 'Pear' },
4747
{ label: 'Orange', value: 'Orange', disabled: false },
4848
];

0 commit comments

Comments
 (0)