Skip to content

Commit e6a2b9a

Browse files
icebobicebob
committed
change input event to change on checlist field
1 parent 01f0554 commit e6a2b9a

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

‎src/fields/core/fieldChecklist.vue

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
.listbox.form-control(v-if="schema.listBox", :disabled="disabled")
44
.list-row(v-for="item in items", :class="{'is-checked': isItemChecked(item)}")
55
label
6-
input(type="checkbox", :checked="isItemChecked(item)", :disabled="disabled", @input="onChanged($event, item)")
6+
input(type="checkbox", :checked="isItemChecked(item)", :disabled="disabled", @change="onChanged($event, item)")
77
| {{ getItemName(item) }}
88

99
.combobox.form-control(v-if="!schema.listBox", :disabled="disabled")
@@ -14,7 +14,7 @@
1414
.dropList
1515
.list-row(v-if="comboExpanded", v-for="item in items", :class="{'is-checked': isItemChecked(item)}")
1616
label
17-
input(type="checkbox", :checked="isItemChecked(item)", :disabled="disabled", @input="onChanged($event, item)")
17+
input(type="checkbox", :checked="isItemChecked(item)", :disabled="disabled", @change="onChanged($event, item)")
1818
| {{ getItemName(item) }}
1919
</template>
2020

‎test/unit/specs/fields/fieldChecklist.spec.js

+12-12
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ describe("fieldChecklist.vue", function() {
8383

8484
it("model value should be the listbox value if changed", (done) => {
8585
checkboxes[0].checked = true;
86-
trigger(checkboxes[0], "input");
86+
trigger(checkboxes[0], "change");
8787

8888
vm.$nextTick( () => {
8989
expect(model.skills).to.be.deep.equal(["ReactJS", "HTML5"]);
@@ -122,7 +122,7 @@ describe("fieldChecklist.vue", function() {
122122

123123
it(".list-row with checked input should have a 'is-checked' class after listbox value is changed", (done) => {
124124
checkboxes[0].checked = true;
125-
trigger(checkboxes[0], "input");
125+
trigger(checkboxes[0], "change");
126126

127127
vm.$nextTick( () => {
128128
expect(listRowList[0].classList.contains("is-checked")).to.be.true;
@@ -206,7 +206,7 @@ describe("fieldChecklist.vue", function() {
206206

207207
it("model value should be the listbox value if changed", (done) => {
208208
checkboxes[0].checked = true;
209-
trigger(checkboxes[0], "input");
209+
trigger(checkboxes[0], "change");
210210

211211
vm.$nextTick( () => {
212212
expect(model.skills).to.be.deep.equal([3, 1]);
@@ -246,7 +246,7 @@ describe("fieldChecklist.vue", function() {
246246

247247
it(".list-row with checked input should have a 'is-checked' class after listbox value is changed", (done) => {
248248
checkboxes[0].checked = true;
249-
trigger(checkboxes[0], "input");
249+
trigger(checkboxes[0], "change");
250250

251251
vm.$nextTick( () => {
252252
expect(listRowList[0].classList.contains("is-checked")).to.be.true;
@@ -334,7 +334,7 @@ describe("fieldChecklist.vue", function() {
334334

335335
it("model value should be the listbox value if changed", (done) => {
336336
checkboxes[0].checked = true;
337-
trigger(checkboxes[0], "input");
337+
trigger(checkboxes[0], "change");
338338

339339
vm.$nextTick( () => {
340340
expect(model.skills).to.be.deep.equal([3, 1]);
@@ -374,7 +374,7 @@ describe("fieldChecklist.vue", function() {
374374

375375
it(".list-row with checked input should have a 'is-checked' class after listbox value is changed", (done) => {
376376
checkboxes[0].checked = true;
377-
trigger(checkboxes[0], "input");
377+
trigger(checkboxes[0], "change");
378378

379379
vm.$nextTick( () => {
380380
expect(listRowList[0].classList.contains("is-checked")).to.be.true;
@@ -456,7 +456,7 @@ describe("fieldChecklist.vue", function() {
456456

457457
it("model value should be the listbox value if changed", (done) => {
458458
checkboxes[0].checked = true;
459-
trigger(checkboxes[0], "input");
459+
trigger(checkboxes[0], "change");
460460

461461
vm.$nextTick( () => {
462462
expect(model.skills).to.be.deep.equal([3, 1]);
@@ -496,7 +496,7 @@ describe("fieldChecklist.vue", function() {
496496

497497
it(".list-row with checked input should have a 'is-checked' class after listbox value is changed", (done) => {
498498
checkboxes[0].checked = true;
499-
trigger(checkboxes[0], "input");
499+
trigger(checkboxes[0], "change");
500500

501501
vm.$nextTick( () => {
502502
expect(listRowList[0].classList.contains("is-checked")).to.be.true;
@@ -606,7 +606,7 @@ describe("fieldChecklist.vue", function() {
606606

607607
it("model value should be the dropList value if changed (add)", (done) => {
608608
checkboxes[0].checked = true;
609-
trigger(checkboxes[0], "input");
609+
trigger(checkboxes[0], "change");
610610

611611
vm.$nextTick( () => {
612612
expect(model.skills).to.be.deep.equal(["ReactJS", "HTML5"]);
@@ -617,7 +617,7 @@ describe("fieldChecklist.vue", function() {
617617

618618
it("model value should be the checklist value if changed (remove)", (done) => {
619619
checkboxes[0].checked = false;
620-
trigger(checkboxes[0], "input");
620+
trigger(checkboxes[0], "change");
621621

622622
vm.$nextTick( () => {
623623
expect(model.skills).to.be.deep.equal(["ReactJS"]);
@@ -629,7 +629,7 @@ describe("fieldChecklist.vue", function() {
629629
it("model value should be the dropList value if changed (null)", (done) => {
630630
model.skills = null;
631631
checkboxes[0].checked = true;
632-
trigger(checkboxes[0], "input");
632+
trigger(checkboxes[0], "change");
633633

634634
vm.$nextTick( () => {
635635
expect(model.skills).to.be.deep.equal(["HTML5"]);
@@ -672,7 +672,7 @@ describe("fieldChecklist.vue", function() {
672672

673673
it(".list-row with checked input should have a 'is-checked' class after listbox value is changed", (done) => {
674674
checkboxes[0].checked = true;
675-
trigger(checkboxes[0], "input");
675+
trigger(checkboxes[0], "change");
676676

677677
vm.$nextTick( () => {
678678
listRowList = dropList.querySelectorAll(".list-row");

0 commit comments

Comments
 (0)