Skip to content

Commit c728597

Browse files
author
Lionel Bijaoui
committed
Added props validation for "tag" and unit test for it.
1 parent 90b0767 commit c728597

File tree

2 files changed

+31
-3
lines changed

2 files changed

+31
-3
lines changed

src/formGenerator.vue

+6-3
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,12 @@ div
7373
},
7474
7575
tag: {
76-
type: String,
77-
default: 'fieldset'
78-
}
76+
type: String,
77+
default: "fieldset",
78+
validator: function (value) {
79+
return value.length > 0;
80+
}
81+
}
7982
},
8083
8184
data () {

test/unit/specs/VueFormGenerator.spec.js

+25
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,31 @@ describe("VueFormGenerator.vue", () => {
4646
expect(el.getElementsByTagName("fieldset")).to.be.length(1);
4747
});
4848

49+
});
50+
51+
describe("with empty schema and custom tag", () => {
52+
let schema = {};
53+
54+
beforeEach( () => {
55+
let elm = document.createElement("div");
56+
vm = new Vue({
57+
// eslint-disable-next-line quotes
58+
template: `<vue-form-generator :schema="schema" ref="form" tag="div"></vue-form-generator>`,
59+
data: {
60+
schema
61+
}
62+
}).$mount(elm);
63+
64+
el = vm.$el;
65+
66+
return [el, vm];
67+
});
68+
69+
it("should be create fieldset", () => {
70+
expect(vm.$el).to.be.exist;
71+
expect(el.getElementsByTagName("div")).to.be.length(1);
72+
});
73+
4974
});
5075

5176
describe("check form-group classes", () => {

0 commit comments

Comments
 (0)