From 6f1719db710653682b10f98f6a9fcac0d9d00740 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vin=C3=ADcius=20Hoyer?= <contact@vhoyer.dev>
Date: Tue, 5 Dec 2023 12:39:39 -0300
Subject: [PATCH 1/4] :sparkles: (form-control-has-label): Add meter, output,
 and progress to default list of controls to check

---
 src/rules/form-control-has-label.ts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/rules/form-control-has-label.ts b/src/rules/form-control-has-label.ts
index 9b147400..bc382459 100644
--- a/src/rules/form-control-has-label.ts
+++ b/src/rules/form-control-has-label.ts
@@ -81,6 +81,9 @@ const rule: Rule.RuleModule = {
           "input",
           "textarea",
           "select",
+          "meter",
+          "output",
+          "progress",
           ...(options.controlComponents || [])
         ];
 

From d41b34afedd1d355a2e9c6a67115687a3e307a5b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vin=C3=ADcius=20Hoyer?= <contact@vhoyer.dev>
Date: Tue, 5 Dec 2023 13:02:50 -0300
Subject: [PATCH 2/4] :bug: (form-control-has-label): allow form-element to
 pass if it has an id

Closes #924
---
 .../__tests__/form-control-has-label.test.ts  | 24 +++++++++++++--
 src/rules/form-control-has-label.ts           | 29 ++++++++++++++-----
 2 files changed, 43 insertions(+), 10 deletions(-)

diff --git a/src/rules/__tests__/form-control-has-label.test.ts b/src/rules/__tests__/form-control-has-label.test.ts
index 2442afd3..da466eb9 100644
--- a/src/rules/__tests__/form-control-has-label.test.ts
+++ b/src/rules/__tests__/form-control-has-label.test.ts
@@ -5,8 +5,22 @@ makeRuleTester("form-control-has-label", rule, {
   valid: [
     "<label for=''><input type='text' /></label>",
     "<input type='text' aria-label='test' />",
-    "<label for=''>text</label><input type='text' />",
     "<input type='button'>",
+    `
+      <div class="checkbox">
+        <label for="check">I agree</label>
+        <input id="check" type="checkbox" />
+      </div>
+    `,
+    `
+      <div class="checkbox">
+        <input id="myCheckbox" type="checkbox" aria-describedby="myCheckboxInfo" />
+        <div class="checkbox-label">
+          <label for="myCheckbox">I agree</label>
+          <p id="myCheckboxInfo">Here is some extra info what I agree upon</p>
+        </div>
+      </div>
+    `,
     `
       <label>
         <div>
@@ -29,9 +43,15 @@ makeRuleTester("form-control-has-label", rule, {
     "<b-form-input />"
   ],
   invalid: [
+    "<label for=''>text</label><input type='text' />",
+    `
+      <div class="checkbox">
+        <input type="checkbox" />
+        <label>I agree</label>
+      </div>
+    `,
     "<input type='text' />",
     "<textarea type='text'></textarea>",
-    "<custom-label for='input'>text</custom-label><input type='text' id='input' />",
     {
       code: "<div><b-form-input /></div>",
       options: [{ controlComponents: ["b-form-input"] }],
diff --git a/src/rules/form-control-has-label.ts b/src/rules/form-control-has-label.ts
index bc382459..38f34f5a 100644
--- a/src/rules/form-control-has-label.ts
+++ b/src/rules/form-control-has-label.ts
@@ -27,18 +27,30 @@ function isLabelElement(
   return isMatchingElement(node, allLabelComponents);
 }
 
-function hasLabelElement(
+function hasNestedLabelElement(
   node: AST.VElement,
   options: FormControlHasLabelOptions
 ): boolean {
   const { parent } = node;
 
-  return (
-    [parent, ...parent.children].some((node) =>
-      isLabelElement(node, options)
-    ) ||
-    (parent && parent.type === "VElement" && hasLabelElement(parent, options))
-  );
+  if (isLabelElement(parent, options)) {
+    return true;
+  }
+
+  return (parent && parent.type === "VElement" && hasNestedLabelElement(parent, options));
+}
+
+/**
+ * Check if the form control at least has an "id" to be associated with a label
+ * Can't really check for the label with a matching "for" attribute, because
+ * checking every element in the file may lead to bad performance.
+ */
+function hasIdForLabelElement(
+  node: AST.VElement
+): boolean {
+  const id = getElementAttributeValue(node, "id");
+
+  return Boolean(id);
 }
 
 const rule: Rule.RuleModule = {
@@ -104,7 +116,8 @@ const rule: Rule.RuleModule = {
         if (
           !isAriaHidden(node) &&
           !hasAriaLabel(node) &&
-          !hasLabelElement(node, options)
+          !hasNestedLabelElement(node, options) &&
+          !hasIdForLabelElement(node)
         ) {
           context.report({ node: node as any, messageId: "default" });
         }

From 3b78268aade2a04d0df987db60bfc58ef998f15b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vin=C3=ADcius=20Hoyer?= <contact@vhoyer.dev>
Date: Tue, 16 Jan 2024 15:21:48 -0300
Subject: [PATCH 3/4] :wrench: Update moduleResolution for modern node versions
 on tsconfig

---
 tsconfig.json | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tsconfig.json b/tsconfig.json
index 8f674cd6..c4df42ce 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -1,7 +1,8 @@
 {
   "compilerOptions": {
+    "moduleResolution": "nodenext",
+    "module": "nodenext",
     "target": "es2019",
-    "module": "commonjs",
     "strict": true,
     "esModuleInterop": true,
     "resolveJsonModule": true,

From b36a585325e7f5cdfa71f71537100246b4479b0d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vin=C3=ADcius=20Hoyer?= <contact@vhoyer.dev>
Date: Tue, 16 Jan 2024 15:26:57 -0300
Subject: [PATCH 4/4] :rotating_light: Fix prettier errors

---
 src/rules/form-control-has-label.ts | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/rules/form-control-has-label.ts b/src/rules/form-control-has-label.ts
index 38f34f5a..55ab71ec 100644
--- a/src/rules/form-control-has-label.ts
+++ b/src/rules/form-control-has-label.ts
@@ -37,7 +37,11 @@ function hasNestedLabelElement(
     return true;
   }
 
-  return (parent && parent.type === "VElement" && hasNestedLabelElement(parent, options));
+  return (
+    parent &&
+    parent.type === "VElement" &&
+    hasNestedLabelElement(parent, options)
+  );
 }
 
 /**
@@ -45,9 +49,7 @@ function hasNestedLabelElement(
  * Can't really check for the label with a matching "for" attribute, because
  * checking every element in the file may lead to bad performance.
  */
-function hasIdForLabelElement(
-  node: AST.VElement
-): boolean {
+function hasIdForLabelElement(node: AST.VElement): boolean {
   const id = getElementAttributeValue(node, "id");
 
   return Boolean(id);