Skip to content

Allow custom label elements in form-control-has-label #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gavmck opened this issue Nov 12, 2021 · 5 comments
Closed

Allow custom label elements in form-control-has-label #333

gavmck opened this issue Nov 12, 2021 · 5 comments

Comments

@gavmck
Copy link
Contributor

gavmck commented Nov 12, 2021

We have custom label components.
Currently the label-has-for rule supports custom components to validate as labels.
We need to update the form-control-has-label rule to accept custom label definitions.

@gavmck
Copy link
Contributor Author

gavmck commented Nov 12, 2021

PR open with a fix for this one: #334

@gavmck
Copy link
Contributor Author

gavmck commented May 31, 2022

This is merged, do you know what the ETA is for release? @vhoyer

@vhoyer
Copy link
Collaborator

vhoyer commented May 31, 2022

I Don't have an ETA yet as I still don't have access to the npm. Tho Kevin said he would make it so I could release :) I don't think I have access yet since I don't see the package in my npm packages page, but I can try today make a release, if it works, it works if it doesn't, then we will be waiting for a little longer :)

@kddnewton
Copy link
Collaborator

Sorry @vhoyer just added you

@vhoyer
Copy link
Collaborator

vhoyer commented May 31, 2022

it's released! 🎉 will close this here, feel free to reopen or create a new issue if there is anything wrong ;D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants