Skip to content

Skip aria-hidden emojis #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheJaredWilcurt opened this issue Jul 7, 2020 · 1 comment · Fixed by #30
Closed

Skip aria-hidden emojis #29

TheJaredWilcurt opened this issue Jul 7, 2020 · 1 comment · Fixed by #30

Comments

@TheJaredWilcurt
Copy link

<template #label>
  <span aria-hidden>🔽</span>
  Title
</template>
<template #label="{ isOpen }">
  <span aria-hidden>{{ isOpen ? "🔼" : "🔽" }}</span>
  Title
</template>

The above results in this message:

Emojis should be wrapped in , have role="img", and have an accessible description with aria-label or aria-labelledby

If it has an aria-hidden it should skip that message. aria-hidden completely removes the entire element from the accessibility API. So the role and label will not be seen.

@TheJaredWilcurt TheJaredWilcurt changed the title skip emoji's with aria-hidden Skip aria-hidden emojis Jul 7, 2020
@kddnewton
Copy link
Collaborator

Thanks @TheJaredWilcurt! Got a PR for this one coming up, then I'll release a patch version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants