Merge pull request #143 from vue-a11y/fix-130

Fix for #130

Author: kddnewton

CHANGELOG.md

@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a
 
 ## [Unreleased]
 
+### Changed
+
+- Fix `iframe-has-title` such that if the attribute is ommitted completely that it fires correctly.
+
 ## [0.6.1] - 2021-01-21
 
 ### Changed

src/rules/__tests__/iframe-has-title.test.js

@@ -3,5 +3,5 @@ const makeRuleTester = require("./makeRuleTester");
 
 makeRuleTester("iframe-has-title", rule, {
   valid: ["<iframe title='test' />", "<iframe :title='test' />"],
-  invalid: ["<iframe :title='true' />", "<iframe :title='2' />"]
+  invalid: ["<iframe />", "<iframe :title='true' />", "<iframe :title='2' />"]
 });

src/rules/iframe-has-title.js

@@ -1,6 +1,6 @@
 const {
   defineTemplateBodyVisitor,
-  getLiteralAttributeValue,
+  getElementAttributeValue,
   makeDocsURL
 } = require("../utils");
 
@@ -16,9 +16,9 @@ module.exports = {
   create(context) {
     return defineTemplateBodyVisitor(context, {
       "VElement[name='iframe']"(node) {
-        const title = getLiteralAttributeValue(node, "title");
+        const title = getElementAttributeValue(node, "title");
 
-        if (!["string", "object"].includes(typeof title)) {
+        if (title === null || !["string", "object"].includes(typeof title)) {
           context.report({ node, messageId: "default" });
         }
       }