fix(bootstrap): Rename bootstrapping methods

BREAKING CHANGE:
  - import: 
    - angular/angular_dynamic.dart -> angular/application_factory.dart
    - angular/angular_static.dart  -> angular/application_factory_static.dart

  - functions:
    - dynamictApplication()        -> applicationFactory()
    - staticApplication()          -> staticApplicationFactory()

Author: mhevery

example/web/animation.dart

@@ -1,7 +1,7 @@
 library animation;
 
 import 'package:angular/angular.dart';
-import 'package:angular/angular_dynamic.dart';
+import 'package:angular/application_factory.dart';
 import 'package:angular/animate/module.dart';
 
 part 'animation/repeat_demo.dart';
@@ -28,7 +28,7 @@ class AnimationDemoModule extends Module {
   }
 }
 main() {
-  dynamicApplication()
+  applicationFactory()
       .addModule(new AnimationDemoModule())
       .run();
 }

example/web/bouncing_balls.dart

@@ -1,5 +1,5 @@
 import 'package:angular/angular.dart';
-import 'package:angular/angular_dynamic.dart';
+import 'package:angular/application_factory.dart';
 import 'dart:html';
 import 'dart:math';
 import 'dart:core';
@@ -131,5 +131,5 @@ class MyModule extends Module {
 }
 
 main() {
-  dynamicApplication().addModule(new MyModule()).run();
+  applicationFactory().addModule(new MyModule()).run();
 }

example/web/hello_world.dart

@@ -1,5 +1,5 @@
 import 'package:angular/angular.dart';
-import 'package:angular/angular_dynamic.dart';
+import 'package:angular/application_factory.dart';
 
 @NgController(
     selector: '[hello-world-controller]',
@@ -9,7 +9,7 @@ class HelloWorldController {
 }
 
 main() {
-  dynamicApplication()
+  applicationFactory()
       .addModule(new Module()..type(HelloWorldController))
       .run();
 }

example/web/todo.dart

@@ -3,7 +3,7 @@ library todo;
 import 'dart:html';
 
 import 'package:angular/angular.dart';
-import 'package:angular/angular_dynamic.dart';
+import 'package:angular/application_factory.dart';
 import 'package:angular/playback/playback_http.dart';
 
 class Item {
@@ -119,5 +119,5 @@ main() {
     module.type(HttpBackend, implementedBy: PlaybackHttpBackend);
   }
 
-  dynamicApplication().addModule(module).run();
+  applicationFactory().addModule(module).run();
 }

lib/angular.dart

@@ -1,7 +1,7 @@
 library angular;
 
 
-export 'package:angular/bootstrap.dart';
+export 'package:angular/application.dart';
 export 'package:angular/core/module.dart';
 export 'package:angular/directive/module.dart';
 export 'package:angular/core/annotation.dart';

lib/bootstrap.dart renamed to lib/application.dart

@@ -1,12 +1,12 @@
 /**
- * Bootstrapping for Angular applications via [app:dynamic](#angular-app-dynamic) for development,
- * or [app:static](#angular-app-static) for production.
+ * Bootstrapping for Angular applications via [app:factory](#angular-app-factory) for development,
+ * or [app:factory:static](#angular-app-factory-static) for production.
  *
  * In your `main()` function, you bootstrap Angular by explicitly defining and adding a module for
- * your app:
+ * your application:
  *
  *     import 'package:angular/angular.dart';
- *     import 'package:angular/angular_dynamic.dart';
+ *     import 'package:angular/application_factory.dart';
  *
  *     class MyModule extends Module {
  *       MyModule() {
@@ -15,25 +15,27 @@
  *     }
  *
  *     main() {
- *       dynamicApplication()
+ *       applicationFactory()
  *           .addModule(new MyModule())
  *           .run();
  *     }
  *
- * In the code above, we use [dynamicApplication](#angular-app-dynamic) to
+ * In the code above, we use [applicationFactory](#angular-app-factory) to
  * take advantage of [dart:mirrors]
  * (https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/dart-mirrors) during
- * development. When you run the app in Dartium, you are using the implementation found under
- * [app:dynamic](#angular-app-dynamic). Note also that you must explicitly import both
- * `angular.dart` and `angular_dynamic.dart` at the start of your file.
+ * development. When you run the app in Dartium the [app:factory](#angular-app-factory)
+ * implementation allows for quick edit-test development cycle.
  *
- * For production, transformers defined in your `pubspec.yaml` file convert the compiled code to
- * use the [app:static](#angular-app-static) implementation when you run `pub build`. Instead of
- * relying on mirrors, this automatically generates the getters, setters, annotations, and factories
- * needed by Dart for tree shaking in dart2js, ensuring that your final JavaScript code contains
- * only what is used by the root Injector that ngApp creates.
+ * Note that you must explicitly import both `angular.dart` and `application_factory.dart` at
+ * the start of your file.
  *
- * Add the transformers rule shown below to your `pubspec.yaml`:
+ * For production, transformers defined in your `pubspec.yaml` file convert the code to
+ * use the [app:factory:static](#angular-app-factory-static) when you run `pub build`. Instead of
+ * relying on mirrors (which disable tree-shaking and thus generate large JS size), the transformers
+ * generate getters, setters, annotations, and factories needed by Angular. The result is that
+ * `dart2js` can than enable tree-shaking and produce smaller output.
+ *
+ * To enable the transformers add this rule as shown below to your `pubspec.yaml`:
  *
  *     name: angular_dart_example
  *     version: 0.0.1
@@ -55,12 +57,13 @@
  *     transformers:
  *     - angular:
  *         html_files:
- *         - lib/_somelibrary/_some_component.html
+ *         - lib/_some_library_/_some_component_.html
  *
  * If you need a way to build your app without transformers, you can use
- * [staticApplication](#angular-app-static@id_staticApplication) directly, instead of
- * [dynamicApplication](#angular-app-dynamic@id_dynamicApplication). See the documentation for
- * the [app:static](#angular-app-static) library definition for more on this use case.
+ * [staticApplicationFactory](#angular-app-factory-static@id_staticApplicationFactory) directly,
+ * instead of [applicationFactory](#angular-app-factory@id_dynamicApplication). See the
+ * documentation for the [app:factory:static](#angular-app-factory-static) library definition for
+ * more on this use case.
  */
 library angular.app;
 
@@ -80,8 +83,8 @@ import 'package:angular/introspection_js.dart';
 
 /**
  * This is the top level module which describes all Angular components,
- * including services, filters and directives. When writing an Angular application,
- * AngularModule is automatically included.
+ * including services, filters and directives. When instantiating an Angular application
+ * through [applicationFactory](#angular-app-factory), AngularModule is automatically included.
  *
  * You can use AngularModule explicitly when creating a custom Injector that needs to know
  * about Angular services, filters, and directives. When writing tests, this is typically done for
@@ -104,17 +107,19 @@ class AngularModule extends Module {
 }
 
 /**
- * Application is how you configure and run an Angular application. There are two
+ * Application represents configuration for your Angular application. There are two
  * implementations for this abstract class:
  *
- * - [app:dynamic](#angular-app-dynamic) for development, which uses transformers to generate the
- * getters, setters, annotations, and factories needed by [dart:mirrors](https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/dart-mirrors) for tree shaking
- * - [app:static](#angular-app-static), for apps that explicitly specify their own getters,
- * setters, annotations, and factories and do not rely on transformation or  [dart:mirrors]
- * (https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/dart-mirrors)
- *
+ * - [app:factory](#angular-app-factory) for development. In this mode Angular uses [dart:mirrors]
+ *   (https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/dart-mirrors) to
+ *   generate getters, setters, annotations, and factories dynamical at runtime. This mode
+ *   is not ideal for `dart2js` compilation since `dart:mirrors` disable full tree-shaking of the
+ *   resulting codebase.
+ * - [app:factory:static](#angular-app-factory-static), which is used by transformers to generate
+ *   the getters, setters, annotations, and factorise needed by Angular. Because the code
+ *   is statically generated `dart2js` can than use full tree-shaking to produce minimal output
+ *   size.
  */
-
 abstract class Application {
   static _find(String selector, [dom.Element defaultElement]) {
     var element = dom.window.document.querySelector(selector);
@@ -125,9 +130,9 @@ abstract class Application {
     return element;
   }
 
-  final zone = new NgZone();
-  final ngModule = new AngularModule();
-  final modules = <Module>[];
+  final NgZone zone = new NgZone();
+  final AngularModule ngModule = new AngularModule();
+  final List<Module> modules = <Module>[];
   dom.Element element;
 
   dom.Element selector(String selector) => element = _find(selector);

lib/angular_dynamic.dart renamed to lib/application_factory.dart

@@ -2,12 +2,12 @@
  * Bootstrapping for Angular applications via [dart:mirrors](https://api.dartlang
  * .org/apidocs/channels/stable/dartdoc-viewer/dart-mirrors) for development.
  *
- * Angular apps that use  [dynamicApplication](#angular-app-dynamic@id_dynamicApplication) rely on
+ * Angular apps that use  [applicationFactory](#angular-app-factory@id_dynamicApplication) rely on
  * dynamic transformation at compile time to generate the getters, setters, annotations, and
  * factories needed for tree shaking during compilation with `dart2js`. See the [angular:app]
  * (#angular-app) library for a discussion of how this works.
  */
-library angular.app.dynamic;
+library angular.app.factory;
 
 import 'package:di/dynamic_injector.dart';
 import 'package:angular/angular.dart';
@@ -66,4 +66,4 @@ class _DynamicApplication extends Application {
   Injector createInjector() => new DynamicInjector(modules: modules);
 }
 
-Application dynamicApplication() => new _DynamicApplication();
+Application applicationFactory() => new _DynamicApplication();

lib/angular_static.dart renamed to lib/application_factory_static.dart

@@ -1,15 +1,15 @@
 /**
  * Bootstrapping for Angular applications via code generation, for production.
  *
- * Most angular.dart apps rely on dynamic transformation at compile time to generate the artifacts
+ * Most angular.dart apps rely on static transformation at compile time to generate the artifacts
  * needed for tree shaking during compilation with `dart2js`. However,
  * if your deployment environment makes it impossible for you to use transformers,
- * you can call [staticApplication](#angular-app-static@id_staticApplication)
+ * you can call [staticApplicationFactory](#angular-app-factory-static@id_staticApplicationFactory)
  * directly in your `main()` function, and explicitly define the getters, setters, annotations, and
  * factories yourself.
  *
  *     import 'package:angular/angular.dart';
- *     import 'package:angular/angular_static.dart';
+ *     import 'package:angular/application_factory_static.dart';
  *
  *     class MyModule extends Module {
  *       MyModule() {
@@ -18,22 +18,22 @@
  *     }
  *
  *     main() {
- *       staticApplication()
+ *       staticApplicationFactory()
  *           .addModule(new MyModule())
  *           .run();
  *     }
  *
  *  Note that you must explicitly import both
- * `angular.dart` and `angular_static.dart` at the start of your file. See [staticApplication]
- * (#angular-app-static@id_staticApplication) for more on explicit definitions required with this
+ * `angular.dart` and `application_factory_static.dart` at the start of your file. See [staticApplicationFactory]
+ * (#angular-app-factory-static@id_staticApplicationFactory) for more on explicit definitions required with this
  * library.
  *
  */
-library angular.app.static;
+library angular.app.factory.static;
 
 import 'package:di/static_injector.dart';
 import 'package:di/di.dart' show TypeFactory, Injector;
-import 'package:angular/bootstrap.dart';
+import 'package:angular/application.dart';
 import 'package:angular/core/registry.dart';
 import 'package:angular/core/parser/parser.dart';
 import 'package:angular/core/parser/parser_static.dart';
@@ -42,8 +42,9 @@ import 'package:angular/core/registry_static.dart';
 import 'package:angular/change_detection/change_detection.dart';
 import 'package:angular/change_detection/dirty_checking_change_detector_static.dart';
 
-export 'package:angular/core/parser/parser_static.dart' show
-    StaticClosureMap;
+export 'package:angular/change_detection/change_detection.dart' show
+    FieldGetter,
+    FieldSetter;
 
 class _StaticApplication extends Application {
   final Map<Type, TypeFactory> typeFactories;
@@ -64,7 +65,7 @@ class _StaticApplication extends Application {
       new StaticInjector(modules: modules, typeFactories: typeFactories);
 }
 
-Application staticApplication(
+Application staticApplicationFactory(
     Map<Type, TypeFactory> typeFactories,
     Map<Type, Object> metadata,
     Map<String, FieldGetter> fieldGetters,

lib/mock/test_injection.dart

@@ -1,6 +1,6 @@
 library angular.mock.test_injection;
 
-import 'package:angular/angular_dynamic.dart';
+import 'package:angular/application_factory.dart';
 import 'package:angular/mock/module.dart';
 import 'package:di/di.dart';
 import 'package:di/dynamic_injector.dart';
@@ -133,7 +133,7 @@ void setUpInjector() {
   _currentSpecInjector = new _SpecInjector();
   _currentSpecInjector.module((Module m) {
     m
-      ..install(dynamicApplication().ngModule)
+      ..install(applicationFactory().ngModule)
       ..install(new AngularMockModule());
   });
 }

lib/routing/module.dart

@@ -154,7 +154,7 @@ import 'dart:async';
 import 'dart:html';
 
 import 'package:di/di.dart';
-import 'package:angular/bootstrap.dart';
+import 'package:angular/application.dart';
 import 'package:angular/core/annotation_src.dart';
 import 'package:angular/core/module_internal.dart';
 import 'package:angular/core_dom/module_internal.dart';

lib/tools/transformer/static_angular_generator.dart

@@ -22,7 +22,7 @@ class StaticAngularGenerator extends Transformer with ResolverTransformer {
     var asset = transform.primaryInput;
 
     var dynamicApp =
-        resolver.getLibraryFunction('angular.app.dynamic.dynamicApplication');
+        resolver.getLibraryFunction('angular.app.factory.applicationFactory');
     if (dynamicApp == null) {
       // No dynamic app imports, exit.
       transform.addOutput(transform.primaryInput);
@@ -36,10 +36,10 @@ class StaticAngularGenerator extends Transformer with ResolverTransformer {
 
     for (var directive in unit.directives) {
       if (directive is ImportDirective &&
-          directive.uri.stringValue == 'package:angular/angular_dynamic.dart') {
+          directive.uri.stringValue == 'package:angular/application_factory.dart') {
         var uri = directive.uri;
         transaction.edit(uri.beginToken.offset, uri.end,
-            '\'package:angular/angular_static.dart\'');
+            '\'package:angular/application_factory_static.dart\'');
       }
     }
 
@@ -81,7 +81,7 @@ class _NgDynamicToStaticVisitor extends GeneralizingAstVisitor {
   visitMethodInvocation(MethodInvocation m) {
     if (m.methodName.bestElement == ngDynamicFn) {
       transaction.edit(m.methodName.beginToken.offset,
-          m.methodName.endToken.end, 'staticApplication');
+          m.methodName.endToken.end, 'staticApplicationFactory');
 
       var args = m.argumentList;
       transaction.edit(args.beginToken.offset + 1, args.end - 1,

scripts/generate-documentation.sh

@@ -24,9 +24,9 @@ cat README-orig.md | sed "1s/^AngularDart.*/AngularDart/" > README.md
     angular/routing/module.dart \
     angular/mock/module.dart \
     angular/perf/module.dart \
-    angular/angular_dynamic.dart \
-    angular/angular_static.dart \
-    angular/bootstrap.dart \
+    angular/application_factory.dart \
+    angular/application_factory_static.dart \
+    angular/application.dart \
     angular/introspection.dart \
     di/di.dart \
     route_hierarchical/client.dart \

test/_specs.dart

@@ -14,7 +14,7 @@ export 'package:mock/mock.dart';
 export 'package:di/di.dart';
 export 'package:di/dynamic_injector.dart';
 export 'package:angular/angular.dart';
-export 'package:angular/bootstrap.dart';
+export 'package:angular/application.dart';
 export 'package:angular/introspection.dart';
 export 'package:angular/core/annotation.dart';
 export 'package:angular/core/registry.dart';