Skip to content

Commit 3977ea6

Browse files
adrianchirisvrindle
authored andcommitted
Bump golangci-lint version (openshift#77)
typecheck seems to not play nice with go 1.20[1]. with the current version of golangci-lint we are using. bump to latest release. [1] golangci/golangci-lint#3420 Signed-off-by: adrianc <[email protected]>
1 parent 45fa650 commit 3977ea6

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

.golangci.yml

+3-8
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,11 @@ linters-settings:
2525
min-complexity: 30
2626
goimports:
2727
local-prefixes: github.com/Mellanox/ib-sriov-cni
28-
golint:
29-
min-confidence: 0
3028
gomnd:
3129
settings:
3230
mnd:
3331
# don't include the "operation" and "assign"
34-
checks: argument,case,condition,return
32+
checks: [argument,case,condition,return]
3533
govet:
3634
check-shadowing: true
3735
settings:
@@ -55,19 +53,18 @@ linters:
5553
disable-all: true
5654
enable:
5755
- bodyclose
58-
- deadcode
5956
- depguard
6057
- dogsled
6158
- dupl
6259
- errcheck
60+
- exportloopref
6361
- funlen
6462
- gochecknoinits
6563
- goconst
6664
- gocritic
6765
- gocognit
6866
- gofmt
6967
- goimports
70-
- golint
7168
- gomnd
7269
- goprintffuncname
7370
- gosec
@@ -78,16 +75,14 @@ linters:
7875
- misspell
7976
- nakedret
8077
- prealloc
78+
- revive
8179
- rowserrcheck
82-
- scopelint
8380
- staticcheck
84-
- structcheck
8581
- stylecheck
8682
- typecheck
8783
- unconvert
8884
- unparam
8985
- unused
90-
- varcheck
9186
- whitespace
9287

9388
issues:

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ GOLANGCI_LINT = $(GOBIN)/golangci-lint
4343
# golangci-lint version should be updated periodically
4444
# we keep it fixed to avoid it from unexpectedly failing on the project
4545
# in case of a version bump
46-
GOLANGCI_LINT_VER = v1.46.2
46+
GOLANGCI_LINT_VER = v1.51.2
4747
TIMEOUT = 15
4848
Q = $(if $(filter 1,$V),,@)
4949

0 commit comments

Comments
 (0)