Don't mutated passed options

maschwenk · maschwenk · commit 03e7997fd0f2 · 2018-09-20T21:53:01.000-07:00
diff --git a/ext/redcarpet/rc_markdown.c b/ext/redcarpet/rc_markdown.c
@@ -115,8 +115,8 @@ static VALUE rb_redcarpet_md__new(int argc, VALUE *argv, VALUE klass)
 
 	/* Merge the current options in the @options hash */
 	if (hash != Qnil) {
-		rndr_options = rb_iv_get(rb_rndr, "@options");
-		rb_funcall(rndr_options, rb_intern("merge!"), 1, hash);
+		rndr_options = rb_funcall(rb_iv_get(rb_rndr, "@options"), rb_intern("merge"), 1, hash);
+		rb_iv_set(rb_rndr, "@options", rndr_options);
 	}
 
 	markdown = sd_markdown_new(extensions, 16, &rndr->callbacks, &rndr->options);

Original file line number	Diff line number	Diff line change
`@@ -115,8 +115,8 @@ static VALUE rb_redcarpet_md__new(int argc, VALUE *argv, VALUE klass)`
`115`	`115`
`116`	`116`	`/* Merge the current options in the @options hash */`
`117`	`117`	`if (hash != Qnil) {`
`118`		`- rndr_options = rb_iv_get(rb_rndr, "@options");`
`119`		`- rb_funcall(rndr_options, rb_intern("merge!"), 1, hash);`
	`118`	`+ rndr_options = rb_funcall(rb_iv_get(rb_rndr, "@options"), rb_intern("merge"), 1, hash);`
	`119`	`+ rb_iv_set(rb_rndr, "@options", rndr_options);`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`markdown = sd_markdown_new(extensions, 16, &rndr->callbacks, &rndr->options);`