Skip to content

Commit 8b39c11

Browse files
authored
fix(vitest): show error when calling API on files that user has no access to (#4085)
1 parent 2fafc00 commit 8b39c11

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

packages/ui/client/components/views/ViewReport.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ function escapeHtml(unsafe: string) {
3535
3636
function createHtmlError(filter: Convert, error: ErrorWithDiff) {
3737
let htmlError = ''
38-
if (error.message.includes('\x1B'))
38+
if (error.message?.includes('\x1B'))
3939
htmlError = `<b>${error.nameStr || error.name}</b>: ${filter.toHtml(escapeHtml(error.message))}`
4040
4141
const startStrWithX1B = error.stackStr?.includes('\x1B')

packages/vitest/src/api/setup.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,20 +80,19 @@ export function setup(vitestOrWorkspace: Vitest | WorkspaceProject, server?: Vit
8080
return fs.readFile(id, 'utf-8')
8181
},
8282
async saveTestFile(id, content) {
83-
// can save only already existing test file
8483
if (!ctx.state.filesMap.has(id) || !existsSync(id))
85-
return
84+
throw new Error(`Test file "${id}" was not registered, so it cannot be updated using the API.`)
8685
return fs.writeFile(id, content, 'utf-8')
8786
},
8887
async saveSnapshotFile(id, content) {
8988
if (!ctx.snapshot.resolvedPaths.has(id))
90-
return
89+
throw new Error(`Snapshot file "${id}" does not exist.`)
9190
await fs.mkdir(dirname(id), { recursive: true })
9291
return fs.writeFile(id, content, 'utf-8')
9392
},
9493
async removeSnapshotFile(id) {
9594
if (!ctx.snapshot.resolvedPaths.has(id) || !existsSync(id))
96-
return
95+
throw new Error(`Snapshot file "${id}" does not exist.`)
9796
return fs.unlink(id)
9897
},
9998
snapshotSaved(snapshot) {

0 commit comments

Comments
 (0)