chore(deps): update dependency @antfu/eslint-config to v4 (#7407)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Vladimir Sheremet <[email protected]>

Author: renovate[bot]

docs/guide/migration.md

@@ -265,7 +265,8 @@ JSON reporter now prints `task.meta` for every assertion result.
 Previously `vi.fn<TArgs, TReturn>` accepted two generic types separately for arguments and return value. This is changed to directly accept a function type `vi.fn<T>` to simplify the usage.
 
 ```ts
-import { type Mock, vi } from 'vitest'
+import { vi } from 'vitest'
+import type { Mock } from 'vitest'
 
 const add = (x: number, y: number): number => x + y
 

package.json

@@ -36,7 +36,7 @@
     "test:browser:playwright": "pnpm -C test/browser run test:playwright"
   },
   "devDependencies": {
-    "@antfu/eslint-config": "^3.16.0",
+    "@antfu/eslint-config": "^4.8.1",
     "@antfu/ni": "^23.3.1",
     "@playwright/test": "^1.50.1",
     "@rollup/plugin-commonjs": "^28.0.2",

packages/browser/src/client/client.ts

@@ -1,6 +1,7 @@
 import type { CancelReason } from '@vitest/runner'
+import type { BirpcReturn } from 'birpc'
 import type { WebSocketBrowserEvents, WebSocketBrowserHandlers } from '../node/types'
-import { type BirpcReturn, createBirpc } from 'birpc'
+import { createBirpc } from 'birpc'
 import { parse, stringify } from 'flatted'
 import { getBrowserState } from './utils'
 

packages/browser/src/client/orchestrator.ts

@@ -1,6 +1,6 @@
+import type { GlobalChannelIncomingEvent, IframeChannelEvent, IframeChannelIncomingEvent } from '@vitest/browser/client'
 import type { SerializedConfig } from 'vitest'
-import { channel, client } from '@vitest/browser/client'
-import { globalChannel, type GlobalChannelIncomingEvent, type IframeChannelEvent, type IframeChannelIncomingEvent } from '@vitest/browser/client'
+import { channel, client, globalChannel } from '@vitest/browser/client'
 import { generateHash } from '@vitest/runner/utils'
 import { relative } from 'pathe'
 import { getUiAPI } from './ui'

packages/browser/src/client/tester/locators/index.ts

@@ -10,6 +10,7 @@ import type {
   UserEventSelectOptions,
   UserEventUploadOptions,
 } from '@vitest/browser/context'
+import type { ParsedSelector } from 'ivya'
 import { page, server } from '@vitest/browser/context'
 import {
   getByAltTextSelector,
@@ -20,7 +21,7 @@ import {
   getByTextSelector,
   getByTitleSelector,
   Ivya,
-  type ParsedSelector,
+
 } from 'ivya'
 import { ensureAwaited, getBrowserState } from '../../utils'
 import { getElementError } from '../public-utils'

packages/browser/src/client/tester/public-utils.ts

@@ -1,6 +1,8 @@
-import { type Locator, type LocatorSelectors, page } from '@vitest/browser/context'
+import type { Locator, LocatorSelectors } from '@vitest/browser/context'
+import type { StringifyOptions } from 'vitest/utils'
+import { page } from '@vitest/browser/context'
 import { asLocator } from 'ivya'
-import { stringify, type StringifyOptions } from 'vitest/utils'
+import { stringify } from 'vitest/utils'
 
 export function getElementLocatorSelectors(element: Element): LocatorSelectors {
   const locator = page.elementLocator(element)

packages/browser/src/client/tester/snapshot.ts

@@ -1,6 +1,7 @@
 import type { VitestBrowserClient } from '@vitest/browser/client'
 import type { SnapshotEnvironment } from 'vitest/snapshot'
-import { originalPositionFor, type ParsedStack, TraceMap } from 'vitest/utils'
+import type { ParsedStack } from 'vitest/utils'
+import { originalPositionFor, TraceMap } from 'vitest/utils'
 
 export class VitestBrowserSnapshotEnvironment implements SnapshotEnvironment {
   private sourceMaps = new Map<string, any>()

packages/browser/src/node/plugin.ts

@@ -1,5 +1,6 @@
 import type { Stats } from 'node:fs'
 import type { HtmlTagDescriptor } from 'vite'
+import type { Plugin } from 'vitest/config'
 import type { Vitest } from 'vitest/node'
 import type { ParentBrowserProject } from './projectParent'
 import { lstatSync, readFileSync } from 'node:fs'
@@ -9,7 +10,7 @@ import { toArray } from '@vitest/utils'
 import MagicString from 'magic-string'
 import { basename, dirname, extname, resolve } from 'pathe'
 import sirv from 'sirv'
-import { coverageConfigDefaults, type Plugin } from 'vitest/config'
+import { coverageConfigDefaults } from 'vitest/config'
 import { getFilePoolName, resolveApiServerConfig, resolveFsAllow, distDir as vitestDist } from 'vitest/node'
 import { distRoot } from './constants'
 import { createOrchestratorMiddleware } from './middlewares/orchestratorMiddleware'

packages/browser/src/node/projectParent.ts

@@ -1,3 +1,4 @@
+import type { StackTraceParserOptions } from '@vitest/utils/source-map'
 import type { HtmlTagDescriptor } from 'vite'
 import type { ErrorWithDiff, ParsedStack } from 'vitest'
 import type {
@@ -12,7 +13,7 @@ import type {
 import type { BrowserServerState } from './state'
 import { readFileSync } from 'node:fs'
 import { readFile } from 'node:fs/promises'
-import { parseErrorStacktrace, parseStacktrace, type StackTraceParserOptions } from '@vitest/utils/source-map'
+import { parseErrorStacktrace, parseStacktrace } from '@vitest/utils/source-map'
 import { dirname, join, resolve } from 'pathe'
 import { BrowserServerCDPHandler } from './cdp'
 import builtinCommands from './commands/index'

packages/coverage-istanbul/src/provider.ts

@@ -1,11 +1,13 @@
+import type { CoverageMap } from 'istanbul-lib-coverage'
+import type { Instrumenter } from 'istanbul-lib-instrument'
 import type { ProxifiedModule } from 'magicast'
 import type { CoverageProvider, ReportContext, ResolvedCoverageOptions, Vitest } from 'vitest/node'
 import { promises as fs } from 'node:fs'
 // @ts-expect-error missing types
 import { defaults as istanbulDefaults } from '@istanbuljs/schema'
 import createDebug from 'debug'
-import libCoverage, { type CoverageMap } from 'istanbul-lib-coverage'
-import { createInstrumenter, type Instrumenter } from 'istanbul-lib-instrument'
+import libCoverage from 'istanbul-lib-coverage'
+import { createInstrumenter } from 'istanbul-lib-instrument'
 import libReport from 'istanbul-lib-report'
 import libSourceMaps from 'istanbul-lib-source-maps'
 import reports from 'istanbul-reports'

packages/coverage-v8/src/index.ts

@@ -1,6 +1,7 @@
+import type { Profiler } from 'node:inspector'
 import type { CoverageProviderModule } from 'vitest/node'
 import type { ScriptCoverageWithOffset, V8CoverageProvider } from './provider'
-import inspector, { type Profiler } from 'node:inspector'
+import inspector from 'node:inspector'
 import { fileURLToPath } from 'node:url'
 import { provider } from 'std-env'
 import { loadProvider } from './load-provider'

packages/expect/src/jest-asymmetric-matchers.ts

@@ -1,3 +1,5 @@
+/* eslint-disable unicorn/no-instanceof-builtins -- we check both */
+
 import type { ChaiPlugin, MatcherState } from './types'
 import { GLOBAL_EXPECT } from './constants'
 import {
@@ -242,7 +244,7 @@ export class Any extends AsymmetricMatcher<any> {
     }
 
     if (this.sample === Function) {
-      return typeof other == 'function' || other instanceof Function
+      return typeof other == 'function' || typeof other === 'function'
     }
 
     if (this.sample === Boolean) {

packages/mocker/src/node/automockPlugin.ts

@@ -1,15 +1,11 @@
 import type { Plugin } from 'vite'
+import type { Declaration, ExportDefaultDeclaration, ExportNamedDeclaration, Expression, Pattern, Positioned, Program } from './esmWalker'
 import MagicString from 'magic-string'
 import { cleanUrl } from '../utils'
 import {
-  type Declaration,
-  type ExportDefaultDeclaration,
-  type ExportNamedDeclaration,
-  type Expression,
+
   getArbitraryModuleIdentifier,
-  type Pattern,
-  type Positioned,
-  type Program,
+
 } from './esmWalker'
 
 export interface AutomockPluginOptions {

packages/mocker/src/node/mockerPlugin.ts

@@ -1,11 +1,13 @@
 import type { Plugin, ViteDevServer } from 'vite'
+import type { AutomockPluginOptions } from './automockPlugin'
+import type { HoistMocksPluginOptions } from './hoistMocksPlugin'
+
 import { readFile } from 'node:fs/promises'
 import { fileURLToPath } from 'node:url'
-
 import { resolve } from 'pathe'
-import { automockPlugin, type AutomockPluginOptions } from './automockPlugin'
+import { automockPlugin } from './automockPlugin'
 import { dynamicImportPlugin } from './dynamicImportPlugin'
-import { hoistMocksPlugin, type HoistMocksPluginOptions } from './hoistMocksPlugin'
+import { hoistMocksPlugin } from './hoistMocksPlugin'
 import { interceptorPlugin } from './interceptorPlugin'
 import { ServerMockResolver } from './resolver'
 

packages/runner/src/suite.ts

@@ -785,7 +785,7 @@ function createTest(
 function formatName(name: string | Function) {
   return typeof name === 'string'
     ? name
-    : name instanceof Function
+    : typeof name === 'function'
       ? name.name || '<anonymous>'
       : String(name)
 }

packages/runner/src/utils/tasks.ts

@@ -1,5 +1,6 @@
+import type { Arrayable } from '@vitest/utils'
 import type { Suite, Task, Test } from '../types/tasks'
-import { type Arrayable, toArray } from '@vitest/utils'
+import { toArray } from '@vitest/utils'
 
 /**
  * @deprecated use `isTestCase` instead

packages/ui/client/composables/explorer/collapse.ts

@@ -69,14 +69,14 @@ function collapseAllNodes(nodes: UITaskTreeNode[]) {
   }
 }
 
-function * collectChildNodes(node: UITaskTreeNode, itself: boolean): Generator<string> {
+function* collectChildNodes(node: UITaskTreeNode, itself: boolean): Generator<string> {
   if (itself) {
     yield node.id
   }
 
   if (isParentNode(node)) {
     for (let i = 0; i < node.tasks.length; i++) {
-      yield * collectChildNodes(node.tasks[i], true)
+      yield* collectChildNodes(node.tasks[i], true)
     }
   }
 }

packages/ui/client/composables/explorer/collector.ts

@@ -106,7 +106,7 @@ export function runCollect(
 }
 
 function* collectRunningTodoTests() {
-  yield * uiEntries.value.filter(isRunningTestNode)
+  yield* uiEntries.value.filter(isRunningTestNode)
 }
 
 function updateRunningTodoTests() {
@@ -473,7 +473,7 @@ function* testsCollector(suite: Arrayable<Task>): Generator<Test> {
       yield s
     }
     else {
-      yield * testsCollector(s.tasks)
+      yield* testsCollector(s.tasks)
     }
   }
 }

packages/ui/client/composables/explorer/expand.ts

@@ -143,7 +143,7 @@ function* collectExpandedNode(
       if (!ids.has(child.id)) {
         yield node
       }
-      yield * children
+      yield* children
     }
     else if (!ids.has(child.id)) {
       yield child

packages/ui/client/composables/explorer/filter.ts

@@ -37,7 +37,7 @@ export function* filterAll(
   filter: Filter,
 ) {
   for (const node of sortedRootTasks()) {
-    yield * filterNode(node, search, filter)
+    yield* filterNode(node, search, filter)
   }
 }
 
@@ -113,7 +113,7 @@ export function* filterNode(
   )
 
   // collect files, and suites and tests whose parent is expanded
-  yield * entries.filter((node) => {
+  yield* entries.filter((node) => {
     // all file nodes or children of expanded parents
     return isFileNode(node) || (parents.has(node.parentId) && map.get(node.parentId)?.expanded)
   })
@@ -277,7 +277,7 @@ function* visitNode(
   yield [match, node]
   if (isParentNode(node)) {
     for (let i = 0; i < node.tasks.length; i++) {
-      yield * visitNode(node.tasks[i], treeNodes, matcher)
+      yield* visitNode(node.tasks[i], treeNodes, matcher)
     }
   }
 }

packages/ui/client/test.ts

@@ -1,7 +1,8 @@
+import type { RenderOptions } from '@testing-library/vue'
 import {
   render as _render,
   cleanup,
-  type RenderOptions,
+
 } from '@testing-library/vue'
 import { vTooltip } from 'floating-vue'
 import { afterEach } from 'vitest'

packages/utils/src/diff/cleanupSemantic.ts

@@ -65,7 +65,7 @@ class Diff {
  * @return {number} The number of characters common to the start of each
  *     string.
  */
-const diff_commonPrefix = function (text1: string, text2: string): number {
+function diff_commonPrefix(text1: string, text2: string): number {
   // Quick check for common null cases.
   if (!text1 || !text2 || text1.charAt(0) !== text2.charAt(0)) {
     return 0
@@ -99,7 +99,7 @@ const diff_commonPrefix = function (text1: string, text2: string): number {
  * @param {string} text2 Second string.
  * @return {number} The number of characters common to the end of each string.
  */
-const diff_commonSuffix = function (text1: string, text2: string): number {
+function diff_commonSuffix(text1: string, text2: string): number {
   // Quick check for common null cases.
   if (
     !text1
@@ -139,7 +139,7 @@ const diff_commonSuffix = function (text1: string, text2: string): number {
  *     string and the start of the second string.
  * @private
  */
-const diff_commonOverlap_ = function (text1: string, text2: string): number {
+function diff_commonOverlap_(text1: string, text2: string): number {
   // Cache the text lengths to prevent multiple calls.
   const text1_length = text1.length
   const text2_length = text2.length
@@ -189,7 +189,7 @@ const diff_commonOverlap_ = function (text1: string, text2: string): number {
  * Reduce the number of edits by eliminating semantically trivial equalities.
  * @param {!Array.<!diff_match_patch.Diff>} diffs Array of diff tuples.
  */
-const diff_cleanupSemantic = function (diffs: Array<Diff>): void {
+function diff_cleanupSemantic(diffs: Array<Diff>): void {
   let changes = false
   const equalities = [] // Stack of indices where equalities are found.
   let equalitiesLength = 0 // Keeping our own length var is faster in JS.

packages/utils/src/error.ts

@@ -1,5 +1,6 @@
+import type { DiffOptions } from './diff'
 import type { TestError } from './types'
-import { type DiffOptions, printDiffOrStringify } from './diff'
+import { printDiffOrStringify } from './diff'
 import { format, stringify } from './display'
 
 // utils is bundled for any environment and might not support `Element`

packages/utils/src/highlight.ts

@@ -1,5 +1,7 @@
-import { highlight as baseHighlight, type TokenColors } from 'tinyhighlight'
-import c, { type Colors } from 'tinyrainbow'
+import type { TokenColors } from 'tinyhighlight'
+import type { Colors } from 'tinyrainbow'
+import { highlight as baseHighlight } from 'tinyhighlight'
+import c from 'tinyrainbow'
 
 function getDefs(c: Colors): TokenColors {
   const Invalid = (text: string) => c.white(c.bgRed(c.bold(text)))

packages/vite-node/src/source-map-handler.ts

@@ -467,7 +467,7 @@ interface Options {
   retrieveSourceMap?: RetrieveMapHandler
 }
 
-export const install = function (options: Options): void {
+export function install(options: Options): void {
   options = options || {}
 
   // Allow sources to be found by methods other than reading the files
@@ -498,7 +498,7 @@ export const install = function (options: Options): void {
   }
 }
 
-export const resetRetrieveHandlers = function (): void {
+export function resetRetrieveHandlers(): void {
   retrieveFileHandlers.length = 0
   retrieveMapHandlers.length = 0
 

packages/vitest/src/node/cli/cac.ts

@@ -1,8 +1,9 @@
+import type { CAC, Command } from 'cac'
 import type { VitestRunMode } from '../types/config'
 import type { CliOptions } from './cli-api'
 import type { CLIOption, CLIOptions as CLIOptionsConfig } from './cli-config'
 import { toArray } from '@vitest/utils'
-import cac, { type CAC, type Command } from 'cac'
+import cac from 'cac'
 import { normalize } from 'pathe'
 import c from 'tinyrainbow'
 import { version } from '../../../package.json' with { type: 'json' }

packages/vitest/src/node/project.ts

@@ -1,3 +1,4 @@
+import type { GlobOptions } from 'tinyglobby'
 import type {
   ModuleNode,
   TransformResult,
@@ -9,6 +10,7 @@ import type { ProvidedContext } from '../types/general'
 import type { OnTestsRerunHandler, Vitest } from './core'
 import type { GlobalSetupFile } from './globalSetup'
 import type { Logger } from './logger'
+import type { WorkspaceSpec as DeprecatedWorkspaceSpec } from './pool'
 import type { Reporter } from './reporters'
 import type { ParentProjectBrowser, ProjectBrowser } from './types/browser'
 import type {
@@ -24,7 +26,7 @@ import path from 'node:path'
 import { deepMerge, nanoid, slash } from '@vitest/utils'
 import mm from 'micromatch'
 import { isAbsolute, join, relative } from 'pathe'
-import { glob, type GlobOptions } from 'tinyglobby'
+import { glob } from 'tinyglobby'
 import { ViteNodeRunner } from 'vite-node/client'
 import { ViteNodeServer } from 'vite-node/server'
 import { setup } from '../api/setup'
@@ -34,7 +36,7 @@ import { loadGlobalSetupFiles } from './globalSetup'
 import { CoverageTransform } from './plugins/coverageTransform'
 import { MocksPlugins } from './plugins/mocks'
 import { WorkspaceVitestPlugin } from './plugins/workspace'
-import { type WorkspaceSpec as DeprecatedWorkspaceSpec, getFilePoolName } from './pool'
+import { getFilePoolName } from './pool'
 import { TestSpecification } from './spec'
 import { createViteServer } from './vite'