You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+60-22Lines changed: 60 additions & 22 deletions
Original file line number
Diff line number
Diff line change
@@ -207,42 +207,80 @@ You can set the `--debug` option to turn on debugging logs (e.g. `vite --debug r
207
207
208
208
```mermaid
209
209
flowchart TD
210
-
start{Followed issue\ntemplate?}
211
-
start --NO--> close1[Close and ask to\nfollow template]
210
+
start{Followed issue
211
+
template?}
212
+
start --NO--> close1["Close and ask to
213
+
follow template"]
212
214
start --YES--> dupe{Is duplicate?}
213
-
dupe --YES--> close2[Close and point\nto duplicate]
214
-
dupe --NO--> repro{Has proper\nreproduction?}
215
-
repro --NO--> close3[Label: 'needs reproduction'\nbot will auto close if no update\nhas been made in 3 days]
215
+
dupe --YES--> close2[Close and point
216
+
to duplicate]
217
+
dupe --NO--> repro{Has proper
218
+
reproduction?}
219
+
repro --NO--> close3[Label: 'needs reproduction'
220
+
bot will auto close if no update
221
+
has been made in 3 days]
216
222
repro --YES--> real{Is actually a bug?}
217
-
real --NO--> intended{Is the intended\nbehaviour?}
218
-
intended --YES--> explain[Explain and close\npoint to docs if needed]
219
-
intended --NO--> open[Keep open for discussion\nRemove 'pending triage' label]
220
-
real --YES--> real2["1. Remove 'pending triage' label\n2. Add related feature label if\napplicable (e.g. 'feat: ssr')\n3. Add priority and meta labels (see below)"]
221
-
real2 --> unusable{Does the\nbug make Vite\nunusable?}
222
-
unusable --YES--> maj{Does the bug\naffect the majority\nof Vite users?}
223
+
real --NO--> intended{Is the intended
224
+
behaviour?}
225
+
intended --YES--> explain[Explain and close
226
+
point to docs if needed]
227
+
intended --NO--> open[Keep open for discussion
228
+
Remove 'pending triage' label]
229
+
real --YES--> real2["① Remove 'pending triage' label
start --BUG FIX--> strict_bug{"Is this a 'strict fix'?\ni.e. fixes an obvious\noversight with no\nside effects"}
236
-
start --FEATURE--> feature[- Discuss feature necessity\n- Is there a better way\nto address the need?\n- Review code quality\n- Add labels\n- Add to milestone\n- Add to Team Board]
237
-
feature -.-> approve_non_strict[- Run vite-ecosystem-ci if needed\n- Approve if you feel strongly\nthat the PR is needed\nand add to milestone]
238
-
strict_bug --YES--> strict[- Verify the fix locally\n- Review code quality\n- Require test case if applicable\n- Request changes if necessary\n- Add labels]
239
-
strict_bug --NO--> non_strict[Discuss the potential side\neffects of the fix, e.g.\n- Could it introduce implicit\nbehavior changes in other cases?\n- Does it introduce too much changes?\n- Add labels\n- Add to Team Board]
253
+
start{Bug fix
254
+
or
255
+
feature}
256
+
start --BUG FIX--> strict_bug{"Is this a 'strict fix'?
257
+
i.e. fixes an obvious oversight with no side effects"}
feature -.-> approve_non_strict[• Run vite-ecosystem-ci if needed
265
+
• Approve if you feel strongly that the PR is needed and add to milestone]
266
+
strict_bug --YES--> strict[• Verify the fix locally
267
+
• Review code quality
268
+
• Require test case if applicable
269
+
• Request changes if necessary
270
+
• Add labels]
271
+
strict_bug --NO--> non_strict[Discuss the potential side effects of the fix, e.g.
272
+
• Could it introduce implicit behavior changes in other cases?
273
+
• Does it introduce too much changes?
274
+
• Add labels
275
+
• Add to Team Board]
240
276
non_strict -.-> approve_non_strict
241
277
strict --> approve_strict[Approve if ready to be merged]
242
-
approve_strict --> merge_strict[Merge if approved by 2 or\nmore team members]
243
-
approve_non_strict -.-> merge_non_strict[Merge if approved by 2 or\nmore team members\nand the PR has been discussed\n in a team meeting]
278
+
approve_strict --> merge_strict[Merge if approved by 2 or more team members]
279
+
approve_non_strict -.-> merge_non_strict[Merge if approved by 2 or more team members and the PR has been discussed in a team meeting]
244
280
merge_non_strict -.-> merge_extra
245
-
merge_strict --> merge_extra["- Use 'Squash and Merge'\n- Edit commit message to follow convention\n- In commit message body, list\nrelevant issues being fixed\ne.g. 'fix #1234, fix #1235'"]
281
+
merge_strict --> merge_extra["• Use 'Squash and Merge'
282
+
• Edit commit message to follow convention
283
+
• In commit message body, list relevant issues being fixed e.g. 'fix #1234, fix #1235'"]
0 commit comments