fix: add react to optimizeDeps (#9056)

brillout · web-flow · commit bc4a627efe23 · 2022-08-19T14:57:06.000+02:00
diff --git a/packages/plugin-react/src/index.ts b/packages/plugin-react/src/index.ts
@@ -406,7 +406,10 @@ export default function viteReact(opts: Options = {}): PluginOption[] {
     config() {
       return {
         optimizeDeps: {
-          include: [reactJsxRuntimeId, reactJsxDevRuntimeId]
+          // We can't add `react-dom` because the dependency is `react-dom/client`
+          // for React 18 while it's `react-dom` for React 17. We'd need to detect
+          // what React version the user has installed.
+          include: [reactJsxRuntimeId, reactJsxDevRuntimeId, 'react']
         }
       }
     },

Original file line number	Diff line number	Diff line change
`@@ -406,7 +406,10 @@ export default function viteReact(opts: Options = {}): PluginOption[] {`
`406`	`406`	`config() {`
`407`	`407`	`return {`
`408`	`408`	`optimizeDeps: {`
`409`		`- include: [reactJsxRuntimeId, reactJsxDevRuntimeId]`
	`409`	+ // We can't add `react-dom` because the dependency is `react-dom/client`
	`410`	+ // for React 18 while it's `react-dom` for React 17. We'd need to detect
	`411`	`+ // what React version the user has installed.`
	`412`	`+ include: [reactJsxRuntimeId, reactJsxDevRuntimeId, 'react']`
`410`	`413`	`}`
`411`	`414`	`}`
`412`	`415`	`},`