test: ssr external / resolveId test (#18327)

Author: hi-ogawa

packages/vite/src/node/__tests__/environment.spec.ts

@@ -2,13 +2,14 @@ import path from 'node:path'
 import { describe, expect, onTestFinished, test } from 'vitest'
 import type { RollupOutput } from 'rollup'
 import { createServer } from '../server'
-import { defineConfig } from '../config'
+import type { InlineConfig } from '../config'
 import { createBuilder } from '../build'
 import { createServerModuleRunner } from '../ssr/runtime/serverModuleRunner'
 
 describe('custom environment conditions', () => {
-  function getConfig() {
-    return defineConfig({
+  function getConfig(): InlineConfig {
+    return {
+      configFile: false,
       root: import.meta.dirname,
       logLevel: 'error',
       server: {
@@ -116,7 +117,7 @@ describe('custom environment conditions', () => {
           },
         },
       },
-    })
+    }
   }
 
   test('dev', async () => {

packages/vite/src/node/__tests__/fixtures/test-dep-conditions-app/entry-with-module.js

@@ -0,0 +1,2 @@
+import dep from '@vitejs/test-dep-conditions/with-module'
+export default dep

packages/vite/src/node/__tests__/fixtures/test-dep-conditions/dir/index.default.js

@@ -0,0 +1 @@
+export default 'dir/index.default.js'

packages/vite/src/node/__tests__/fixtures/test-dep-conditions/dir/index.module.js

@@ -0,0 +1 @@
+export default 'dir/index.module.js'

packages/vite/src/node/__tests__/fixtures/test-dep-conditions/package.json

@@ -11,6 +11,10 @@
       "worker": "./index.worker.js",
       "browser": "./index.browser.js",
       "default": "./index.default.js"
+    },
+    "./with-module": {
+      "module": "./dir/index.module.js",
+      "default": "./dir/index.default.js"
     }
   }
 }

packages/vite/src/node/__tests__/resolve.spec.ts

@@ -0,0 +1,52 @@
+import { describe, expect, onTestFinished, test } from 'vitest'
+import { createServer } from '../server'
+import { createServerModuleRunner } from '../ssr/runtime/serverModuleRunner'
+
+describe('import and resolveId', () => {
+  async function createTestServer() {
+    const server = await createServer({
+      configFile: false,
+      root: import.meta.dirname,
+      logLevel: 'error',
+      server: {
+        middlewareMode: true,
+      },
+    })
+    onTestFinished(() => server.close())
+    const runner = createServerModuleRunner(server.environments.ssr, {
+      hmr: {
+        logger: false,
+      },
+      sourcemapInterceptor: false,
+    })
+    return { server, runner }
+  }
+
+  test('import first', async () => {
+    const { server, runner } = await createTestServer()
+    const mod = await runner.import(
+      '/fixtures/test-dep-conditions-app/entry-with-module',
+    )
+    const resolved = await server.environments.ssr.pluginContainer.resolveId(
+      '@vitejs/test-dep-conditions/with-module',
+    )
+    expect([mod.default, resolved?.id]).toEqual([
+      'dir/index.default.js',
+      expect.stringContaining('dir/index.module.js'),
+    ])
+  })
+
+  test('resolveId first', async () => {
+    const { server, runner } = await createTestServer()
+    const resolved = await server.environments.ssr.pluginContainer.resolveId(
+      '@vitejs/test-dep-conditions/with-module',
+    )
+    const mod = await runner.import(
+      '/fixtures/test-dep-conditions-app/entry-with-module',
+    )
+    expect([mod.default, resolved?.id]).toEqual([
+      'dir/index.default.js',
+      expect.stringContaining('dir/index.module.js'),
+    ])
+  })
+})