Skip to content

Commit 3013138

Browse files
authored
test: skip hmr-ssr circular test (#19809)
1 parent 36935b5 commit 3013138

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

playground/hmr-ssr/__tests__/hmr-ssr.spec.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -844,7 +844,8 @@ if (!isBuild) {
844844
await untilUpdated(() => hmr('.optional-chaining')?.toString(), '2')
845845
})
846846

847-
test('hmr works for self-accepted module within circular imported files', async () => {
847+
// TODO: this is flaky due to https://github.com/vitejs/vite/issues/19804
848+
test.skip('hmr works for self-accepted module within circular imported files', async () => {
848849
await setupModuleRunner('/self-accept-within-circular/index')
849850
const el = () => hmr('.self-accept-within-circular')
850851
expect(el()).toBe('c')
@@ -864,6 +865,7 @@ if (!isBuild) {
864865
test('hmr should not reload if no accepted within circular imported files', async (ctx) => {
865866
// TODO: Investigate race condition that causes an inconsistent behaviour for the last `untilUpdated`
866867
// assertion where it'll sometimes receive "mod-a -> mod-b (edited) -> mod-c -> mod-a (expected no error)"
868+
// This is probably related to https://github.com/vitejs/vite/issues/19804
867869
ctx.skip()
868870

869871
await setupModuleRunner('/circular/index')

0 commit comments

Comments
 (0)