fix(css): use esbuild legalComments config when minifying CSS (#13661)

Author: niksy

packages/vite/src/node/plugins/css.ts

@@ -1521,6 +1521,7 @@ function resolveMinifyCssEsbuildOptions(
     logLevel: options.logLevel,
     logLimit: options.logLimit,
     logOverride: options.logOverride,
+    legalComments: options.legalComments,
   }
 
   if (

playground/minify/__tests__/minify.spec.ts

@@ -14,5 +14,8 @@ test.runIf(isBuild)('no minifySyntax', () => {
   const cssContent = readFile(path.resolve(assetsDir, cssFile))
 
   expect(jsContent).toContain('{console.log("hello world")}')
+  expect(jsContent).not.toContain('/*! explicit comment */')
+
   expect(cssContent).toContain('color:#ff0000')
+  expect(cssContent).not.toContain('/*! explicit comment */')
 })

playground/minify/dir/module/index.css

@@ -0,0 +1,4 @@
+/*! explicit comment */
+h2 {
+  color: #ff00ff;
+}

playground/minify/dir/module/index.js

@@ -0,0 +1,2 @@
+/*! explicit comment */
+export const msg = `[success] minified module`

playground/minify/dir/module/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "@vitejs/test-minify",
+  "private": true,
+  "type": "module",
+  "version": "0.0.0"
+}

playground/minify/main.js

@@ -1,4 +1,7 @@
 import './test.css'
+import { msg } from 'minified-module'
+
+console.log(msg)
 
 if (window) {
   console.log('hello world')

playground/minify/package.json

@@ -8,5 +8,8 @@
     "build": "vite build",
     "debug": "node --inspect-brk ../../packages/vite/bin/vite",
     "preview": "vite preview"
+  },
+  "dependencies": {
+    "minified-module": "file:./dir/module"
   }
 }

playground/minify/test.css

@@ -1,3 +1,5 @@
+@import 'minified-module/index.css';
+
 h1 {
   /* do not minify as red text */
   color: #ff0000;

playground/minify/vite.config.js

@@ -2,6 +2,7 @@ import { defineConfig } from 'vite'
 
 export default defineConfig({
   esbuild: {
+    legalComments: 'none',
     minifySyntax: false,
   },
 })