Skip to content

Commit 0f1d6be

Browse files
authored
fix: apply SSR externalization heuristic to devDependencies (#4699)
1 parent c53f333 commit 0f1d6be

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

packages/vite/src/node/ssr/ssrExternal.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,12 @@ export function resolveSSRExternal(
2828
return []
2929
}
3030
const pkg = JSON.parse(pkgContent)
31-
const devDeps = Object.keys(pkg.devDependencies || {})
3231
const importedDeps = knownImports.map(getNpmPackageName).filter(isDefined)
33-
const deps = unique([...importedDeps, ...Object.keys(pkg.dependencies || {})])
34-
35-
for (const id of devDeps) {
36-
ssrExternals.add(id)
37-
seen.add(id)
38-
}
32+
const deps = unique([
33+
...importedDeps,
34+
...Object.keys(pkg.devDependencies || {}),
35+
...Object.keys(pkg.dependencies || {})
36+
])
3937

4038
const resolveOptions: InternalResolveOptions = {
4139
root,

0 commit comments

Comments
 (0)