Skip to content

Commit f60ded1

Browse files
committed
test(http): disable a flaky expectation
The error message varies across browsers: Dartium -> "Unexpected character" Dart2JS: - Chrome -> "Unexpected token" - Firefox -> "unexpected character" - IE -> "Invalid character"
1 parent f64f874 commit f60ded1

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

test/core_dom/http_spec.dart

+7-4
Original file line numberDiff line numberDiff line change
@@ -1371,10 +1371,13 @@ void main() {
13711371
http.get('/url').then((_) {
13721372
callbackCalled = true;
13731373
}, onError: (e,s) {
1374-
// Dartium throws "Unexpected character"
1375-
// dart2js/Chrome throws "Unexpected token"
1376-
// dart2js/Firefox throw "unexpected character"
1377-
expect('$e').toContain('nexpected');
1374+
// Dartium -> "Unexpected character"
1375+
// dart2js:
1376+
// - Chrome -> "Unexpected token"
1377+
// - Firefox -> "unexpected character"
1378+
// - IE -> "Invalid character"
1379+
// Commented out as this expectation is not robust !
1380+
// expect('$e', unit.).toContain('nexpected');
13781381
onErrorCalled = true;
13791382
});
13801383
flush();

0 commit comments

Comments
 (0)