Skip to content

Commit 5ef596d

Browse files
committed
feat(testability): whenStable replaces notifyWhenNoOutstandingRequests
BREAKING CHANGE: NOTE: This only affects you if you are calling this API directly. If you are using ProtractorDart, then you are insulated from this change. To update your code, rename all references to the notifyWhenNoOutstandingRequests(callback) method on the testability object to whenStable(callback).
1 parent 158e9aa commit 5ef596d

File tree

6 files changed

+12
-8
lines changed

6 files changed

+12
-8
lines changed

lib/introspection.dart

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ class _Testability implements _JsObjectProxyable {
273273

274274
_Testability(this.node, this.probe);
275275

276-
notifyWhenNoOutstandingRequests(callback) {
276+
whenStable(callback) {
277277
probe.injector.get(VmTurnZone).run(
278278
() => new async.Timer(Duration.ZERO, callback));
279279
}
@@ -326,8 +326,12 @@ class _Testability implements _JsObjectProxyable {
326326
findBindings(bindingString, exactMatch),
327327
'findModels': (modelExpressions, [exactMatch]) =>
328328
findModels(modelExpressions, exactMatch),
329-
'notifyWhenNoOutstandingRequests': (callback) =>
330-
notifyWhenNoOutstandingRequests(() => callback.apply([])),
329+
'whenStable': (callback) =>
330+
whenStable(() => callback.apply([])),
331+
'notifyWhenNoOutstandingRequests': (callback) {
332+
print("DEPRECATED: notifyWhenNoOutstandingRequests has been renamed to whenStable");
333+
whenStable(() => callback.apply([]));
334+
},
331335
'probe': () => _jsProbe(probe),
332336
'scope': () => _jsScopeFromProbe(probe),
333337
'eval': (expr) => probe.scope.eval(expr),

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"karma-junit-reporter": "~0.2.1",
1717
"jasmine-node": "*",
1818
"jasmine-reporters": "~0.4.1",
19-
"protractor-dart": "0.0.3",
19+
"protractor-dart": "0.0.5",
2020
"qq": "*"
2121
},
2222
"licenses": [

pubspec.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ packages:
7272
protractor:
7373
description: protractor
7474
source: hosted
75-
version: "0.0.4"
75+
version: "0.0.5"
7676
route_hierarchical:
7777
description: route_hierarchical
7878
source: hosted

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,5 @@ dev_dependencies:
2929
benchmark_harness: '>=1.0.0'
3030
guinness: '>=0.1.3 <0.2.0'
3131
mock: '>=0.10.0 <0.12.0'
32-
protractor: '0.0.4'
32+
protractor: '0.0.5'
3333
unittest: '>=0.10.1 <0.12.0'

test_e2e/pubspec.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ packages:
1212
protractor:
1313
description: protractor
1414
source: hosted
15-
version: "0.0.4"
15+
version: "0.0.5"

test_e2e/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ environment:
77
sdk: '>=1.3.0'
88
dependencies:
99
js: '>=0.2.0 <0.3.0'
10-
protractor: '0.0.4'
10+
protractor: '0.0.5'

0 commit comments

Comments
 (0)