Skip to content

Commit 12b4ed6

Browse files
committed
test(http): disable a flaky expectation
The error message varies across browsers: Dartium -> "Unexpected character" Dart2JS: - Chrome -> "Unexpected token" - Firefox -> "unexpected character" - IE -> "Invalid character"
1 parent 37cdba1 commit 12b4ed6

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

test/core_dom/http_spec.dart

+7-4
Original file line numberDiff line numberDiff line change
@@ -1370,10 +1370,13 @@ void main() {
13701370
http.get('/url').then((_) {
13711371
callbackCalled = true;
13721372
}, onError: (e,s) {
1373-
// Dartium throws "Unexpected character"
1374-
// dart2js/Chrome throws "Unexpected token"
1375-
// dart2js/Firefox throw "unexpected character"
1376-
expect('$e').toContain('nexpected');
1373+
// Dartium -> "Unexpected character"
1374+
// dart2js:
1375+
// - Chrome -> "Unexpected token"
1376+
// - Firefox -> "unexpected character"
1377+
// - IE -> "Invalid character"
1378+
// Commented out as this expectation is not robust !
1379+
// expect('$e', unit.).toContain('nexpected');
13771380
onErrorCalled = true;
13781381
});
13791382
flush();

0 commit comments

Comments
 (0)