Use ESLint instead of JSHint

Previously: d7ecb98 and 3b0f037. Now we're on trusty with a newer Node.js.

Author: vfaronov

.eslintrc.js

@@ -0,0 +1,24 @@
+module.exports = {
+    "env": {
+        "browser": true
+    },
+    "extends": "eslint:recommended",
+    "rules": {
+        "indent": [
+            "error",
+            4
+        ],
+        "linebreak-style": [
+            "error",
+            "unix"
+        ],
+        "quotes": [
+            "error",
+            "single"
+        ],
+        "semi": [
+            "error",
+            "always"
+        ]
+    }
+};

.travis.yml

@@ -23,7 +23,7 @@ install:
     - pip install -e .
     - pip install -r tools/requirements.txt
     - tools/vnu.sh install
-    - tools/jshint.sh install
+    - tools/eslint.sh install
 
 cache: pip
 
@@ -43,7 +43,7 @@ script:
     # This includes validating an actual HTML report (``showcase.html``).
     - tools/vnu.sh run extra_doc/_build/*.html
     - tools/css_validator.sh httpolice/reports/html.css
-    - tools/jshint.sh run httpolice/reports/html.js
+    - tools/eslint.sh run httpolice/reports/html.js
 
     # Although the main docs (``doc/``) are processed by Read the Docs,
     # we still want to check that they are building OK.

HACKING.rst

@@ -237,7 +237,7 @@ Maintenance
          and changing the version to see if the URL still resolves to 200 (OK).
 
      - Nu Html Checker (in ``tools/vnu.sh``);
-     - JSHint (in ``tools/jshint.sh``).
+     - ESLint (in ``tools/eslint.sh``).
 
   #. Check that everything is OK with the new versions.
      Maybe some Pylint overrides are no longer necessary, etc.

MANIFEST.in

@@ -9,6 +9,7 @@ include .coveragerc
 include .isort.cfg
 include pylintrc
 include pytest.ini
+include .eslintrc.js
 
 # Even though Travis only works on a Git repo,
 # this file is important as a reference on the build procedure.

httpolice/reports/html.js

@@ -1,6 +1,3 @@
-/* jshint browser: true */
-/* jshint -W097 */
-
 'use strict';
 
 function setupNotices() {
@@ -26,12 +23,10 @@ function setupNotices() {
 }
 
 function onButtonClick() {
-    /* jshint -W040 */
     this.parentElement.classList.toggle('collapsed');
 }
 
 function highlightReferences() {
-    /* jshint -W040 */
     var i, referrers, refs, exchange, target;
 
     // Collect references from all contributing elements within this notice.

tools/jshint.sh renamed to tools/eslint.sh

@@ -2,8 +2,8 @@
 
 set -e
 
-VERSION=2.9.5
-BASE=$HOME/install-jshint
+VERSION=4.2.0
+BASE=$HOME/install-eslint
 
 action=$1
 shift
@@ -13,10 +13,10 @@ case $action in
         rm -rf "$BASE"
         mkdir "$BASE"
         cd "$BASE"
-        npm install jshint@$VERSION
+        npm install eslint@$VERSION
         ;;
 
     run)
-        "$BASE/node_modules/.bin/jshint" "$@"
+        "$BASE/node_modules/.bin/eslint" "$@"
         ;;
 esac