From 272de9c372df619b2d26b078152caa43ea5168af Mon Sep 17 00:00:00 2001 From: jbrown17 Date: Sat, 20 Jul 2019 12:56:04 -0300 Subject: [PATCH 1/2] ODIN_II: Fix coverity issue CID 200770: Resource leak --- ODIN_II/SRC/netlist_visualizer.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ODIN_II/SRC/netlist_visualizer.cpp b/ODIN_II/SRC/netlist_visualizer.cpp index 28eb2ac351b..9be4b12ca1d 100644 --- a/ODIN_II/SRC/netlist_visualizer.cpp +++ b/ODIN_II/SRC/netlist_visualizer.cpp @@ -310,7 +310,6 @@ void forward_traversal_net_graph_display(FILE *fp, short marker_value, nnode_t * /*--------------------------------------------------------------------------------------------- * (function: backward_traversal_net_graph_display() - * TODO check if stack of node is freed *-------------------------------------------------------------------------------------------*/ void backward_traversal_net_graph_display(FILE *fp, short marker_value, nnode_t *node) { @@ -393,4 +392,9 @@ void backward_traversal_net_graph_display(FILE *fp, short marker_value, nnode_t /* process next element in net */ index_in_stack ++; } + for(int i = 0; i < num_stack_of_nodes; i++) + { + free_nnode(stack_of_nodes[i]); + } + vtr::free(stack_of_nodes); } From 4734984a7cd80bc34d987d8e52cfe2824f2f5ec9 Mon Sep 17 00:00:00 2001 From: jeanlego Date: Sat, 27 Jul 2019 04:39:09 -0300 Subject: [PATCH 2/2] trigger travis --- ODIN_II/SRC/netlist_visualizer.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/ODIN_II/SRC/netlist_visualizer.cpp b/ODIN_II/SRC/netlist_visualizer.cpp index 9be4b12ca1d..28034e583f9 100644 --- a/ODIN_II/SRC/netlist_visualizer.cpp +++ b/ODIN_II/SRC/netlist_visualizer.cpp @@ -392,6 +392,7 @@ void backward_traversal_net_graph_display(FILE *fp, short marker_value, nnode_t /* process next element in net */ index_in_stack ++; } + for(int i = 0; i < num_stack_of_nodes; i++) { free_nnode(stack_of_nodes[i]);