From 4dd51dd396b5254336ad70f713c82f135d74f0df Mon Sep 17 00:00:00 2001 From: AlexandreSinger Date: Tue, 28 May 2024 22:30:44 -0400 Subject: [PATCH] [CI] Upgraded Actions The Annotations section of the CI was full of deprecation warnings. Node.js 16 actions were deprecated. Upgraded setup-python, checkout, and upload-artifact to their most recent version. See: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ v3 of upload-artifact was also deprecated. v4 claims to be 98% faster, however, may come with some breaking changes. Pertaining to us, artifacts cannot have the same name now and there is a limit of 500 artifacts. See: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ NOTE: Had to leave the nightly tests behind since the self-hosted machine does not support node20. Need to upgrade the machine in order to upgrade these actions. --- .github/workflows/containers.yml | 2 +- .github/workflows/labeler.yml | 2 +- .github/workflows/test.yml | 57 +++++++++++++++++--------------- 3 files changed, 33 insertions(+), 28 deletions(-) diff --git a/.github/workflows/containers.yml b/.github/workflows/containers.yml index 405593c692d..1202dc7fa53 100644 --- a/.github/workflows/containers.yml +++ b/.github/workflows/containers.yml @@ -16,7 +16,7 @@ jobs: steps: - name: 🧰 Repository Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: submodules: 'true' diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml index 77c1faabeb3..0b0d3d9eb02 100644 --- a/.github/workflows/labeler.yml +++ b/.github/workflows/labeler.yml @@ -6,7 +6,7 @@ jobs: triage: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: actions/labeler@master with: repo-token: "${{ secrets.GITHUB_TOKEN }}" diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 00072c99461..7ff3acee97b 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -51,6 +51,8 @@ jobs: steps: + # TODO: This runnner is running on a self-hosted CPU. In order to upgrade + # to v4, need to upgrade the machine to support node20. - uses: actions/checkout@v3 with: submodules: 'true' @@ -71,9 +73,12 @@ jobs: VTR_CMAKE_PARAMS: ${{ matrix.cmake }} NUM_CORES: ${{ matrix.cores }} - - uses: actions/upload-artifact@v3 - if: ${{ always() }} + - name: Upload test results + # TODO: This runnner is running on a self-hosted CPU. In order to upgrade + # to v4, need to upgrade the machine to support node20. + uses: actions/upload-artifact@v3 with: + name: ${{matrix.test}}_test_results path: | **/results*.gz **/plot_*.svg @@ -92,10 +97,10 @@ jobs: - { build_type: 'debug', verbose: '1' } steps: - - uses: actions/setup-python@v4 + - uses: actions/setup-python@v5 with: python-version: 3.10.10 - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: submodules: 'true' - run: ./.github/scripts/install_dependencies.sh @@ -122,10 +127,10 @@ jobs: name: 'F: ${{ matrix.name }}' steps: - - uses: actions/setup-python@v4 + - uses: actions/setup-python@v5 with: python-version: 3.10.10 - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - run: ./.github/scripts/install_dependencies.sh - name: Test @@ -137,10 +142,10 @@ jobs: runs-on: ubuntu-22.04 steps: - - uses: actions/setup-python@v4 + - uses: actions/setup-python@v5 with: python-version: 3.10.10 - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: submodules: 'true' - run: ./.github/scripts/install_dependencies.sh @@ -156,10 +161,10 @@ jobs: runs-on: ubuntu-22.04 steps: - - uses: actions/setup-python@v4 + - uses: actions/setup-python@v5 with: python-version: 3.10.10 - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: submodules: 'true' - run: ./.github/scripts/install_dependencies.sh @@ -236,10 +241,10 @@ jobs: name: 'R: ${{ matrix.name }}' steps: - - uses: actions/setup-python@v4 + - uses: actions/setup-python@v5 with: python-version: 3.10.10 - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: submodules: 'true' - run: ./.github/scripts/install_dependencies.sh @@ -255,7 +260,7 @@ jobs: ./run_reg_test.py ${{ matrix.suite }} -show_failures -j2 - name: Upload regression run files - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: ${{matrix.name}}_run_files path: | @@ -266,7 +271,7 @@ jobs: vtr_flow/**/*.r - name: Upload regression results - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: ${{matrix.name}}_results path: | @@ -291,10 +296,10 @@ jobs: name: 'S: ${{ matrix.name }}' steps: - - uses: actions/setup-python@v4 + - uses: actions/setup-python@v5 with: python-version: 3.10.10 - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: submodules: 'true' @@ -325,10 +330,10 @@ jobs: runs-on: ubuntu-22.04 steps: - - uses: actions/setup-python@v4 + - uses: actions/setup-python@v5 with: python-version: 3.10.10 - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: submodules: 'true' - run: ./.github/scripts/install_dependencies.sh @@ -350,10 +355,10 @@ jobs: runs-on: ubuntu-22.04 steps: - - uses: actions/setup-python@v4 + - uses: actions/setup-python@v5 with: python-version: 3.10.10 - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: submodules: 'true' - run: ./.github/scripts/install_dependencies.sh @@ -376,10 +381,10 @@ jobs: runs-on: ubuntu-22.04 steps: - - uses: actions/setup-python@v4 + - uses: actions/setup-python@v5 with: python-version: 3.10.10 - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: submodules: 'true' - run: ./.github/scripts/install_dependencies.sh @@ -411,10 +416,10 @@ jobs: name: 'B: ${{ matrix.name }}' steps: - - uses: actions/setup-python@v4 + - uses: actions/setup-python@v5 with: python-version: 3.10.10 - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: submodules: 'true' - run: ./.github/scripts/install_dependencies.sh @@ -447,10 +452,10 @@ jobs: runs-on: ubuntu-22.04 steps: - - uses: actions/setup-python@v4 + - uses: actions/setup-python@v5 with: python-version: 3.10.10 - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: submodules: 'true' - run: ./.github/scripts/install_dependencies.sh