Skip to content

[Place] Unnecessary microoptimization in override_delay_model #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AmirhosseinPoolad opened this issue May 16, 2025 · 0 comments
Open
Labels
Good First Issue Good issues for new or first-time contributors VPR VPR FPGA Placement & Routing Tool

Comments

@AmirhosseinPoolad
Copy link
Contributor

AmirhosseinPoolad commented May 16, 2025

Back in 2020 compilers weren't as good as they are now and t_override::operator< generated bad code when using std::tie (See #1225 ), which resulted in code that was faster but is not very easy to read and understand. This seems to no longer be the case anymore and gcc-13 successfully inlines t_override::operator< with std::tie.
https://godbolt.org/z/z8W8jxqqe

If you want to tackle this, you can simply copy paste the implementation in the above link and run vtr and titan benchmarks, compare them with master and make sure the generated assembly isn't actually slower.

@AmirhosseinPoolad AmirhosseinPoolad added VPR VPR FPGA Placement & Routing Tool Good First Issue Good issues for new or first-time contributors labels May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good issues for new or first-time contributors VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

No branches or pull requests

1 participant