Skip to content

[AP] Prepacker Called Twice in AP Flow #2950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amin1377 opened this issue Mar 24, 2025 · 1 comment · Fixed by #2962
Closed

[AP] Prepacker Called Twice in AP Flow #2950

amin1377 opened this issue Mar 24, 2025 · 1 comment · Fixed by #2962
Assignees

Comments

@amin1377
Copy link
Contributor

When AP is enabled, molecules are built twice—once at the beginning of global placement when the AP netlist is created, and again at the start of the full legalizer flow. I think the prepacker should ideally be called only once, although for now it’s not time-critical and doesn’t consume much runtime.

@AlexandreSinger
Copy link
Contributor

AlexandreSinger commented Mar 24, 2025

@amin1377 Thank you so much for flagging this! This is actually a very big issue for the AP flow since we may make references to objects in the prepacker throughout the flow! Luckily, due to the determinism of the prepacker, a Molecule in one prepacker with the same ID will be identical to the other. The prepacker is also never modified in either flow (by design). We were being lucky here. I will look into it sometime next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants