You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixing up some esoteric messages from the compiler and I came across this one.
vtr-vpr/libs/libvtrutil/src/vtr_ndmatrix.h:79:24: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
79 | NdMatrixProxy<T, 1>(const size_t* dim_sizes, const size_t* dim_stride, T* start)
| ^
Here is the simple fix from my tree:
diff --git a/src/vtr-vpr/libs/libvtrutil/src/vtr_ndmatrix.h b/src/vtr-vpr/libs/libvtrutil/src/vtr_ndmatrix.h
index c3a4692..b34a9c8 100644
--- a/src/vtr-vpr/libs/libvtrutil/src/vtr_ndmatrix.h
+++ b/src/vtr-vpr/libs/libvtrutil/src/vtr_ndmatrix.h
@@ -34,7 +34,7 @@ class NdMatrixProxy {
* @param dim_stride: The stride of this dimension (i.e. how many element in memory between indicies of this dimension)
* @param start: Pointer to the start of the sub-matrix this proxy represents
*/
- NdMatrixProxy<T, N>(const size_t* dim_sizes, const size_t* dim_strides, T* start)
+ NdMatrixProxy(const size_t* dim_sizes, const size_t* dim_strides, T* start)
: dim_sizes_(dim_sizes)
, dim_strides_(dim_strides)
, start_(start) {}
@@ -76,7 +76,7 @@ class NdMatrixProxy<T, 1> {
* @param dim_stride: The stride of this dimension (i.e. how many element in memory between indicies of this dimension)
* @param start: Pointer to the start of the sub-matrix this proxy represents
*/
- NdMatrixProxy<T, 1>(const size_t* dim_sizes, const size_t* dim_stride, T* start)
+ NdMatrixProxy(const size_t* dim_sizes, const size_t* dim_stride, T* start)
: dim_sizes_(dim_sizes)
, dim_strides_(dim_stride)
, start_(start) {}
Sorry that this is an issue and not a PR; I'm juggling a lot of things and wanted to just communicate this small thing.
The text was updated successfully, but these errors were encountered:
@heshpdx Thank you for this issue! I have resolved it in a PR. It is strange to put the template IDs in the constructor of any templated class. This must have been done by mistake. I have also found that the copy constructor of this class also does this, so I have resolved that as well.
Fixing up some esoteric messages from the compiler and I came across this one.
Here is the simple fix from my tree:
Sorry that this is an issue and not a PR; I'm juggling a lot of things and wanted to just communicate this small thing.
The text was updated successfully, but these errors were encountered: