Skip to content

VPR Pack: Replace hand-implemented linked lists to std::lists #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmah76 opened this issue Jul 7, 2022 · 4 comments
Open

VPR Pack: Replace hand-implemented linked lists to std::lists #2088

jmah76 opened this issue Jul 7, 2022 · 4 comments
Assignees

Comments

@jmah76
Copy link
Contributor

jmah76 commented Jul 7, 2022

Related to PR #2084

Lists such as the ones vpr/src/base/vtr_types.cpp (line 236) might be better implemented as std::lists. Refer to #2084 (comment)

@jmah76 jmah76 self-assigned this Jul 7, 2022
@jmah76 jmah76 changed the title VPR Pack: Replace hand-implemented linked lists to C++'s std::lists VPR Pack: Replace hand-implemented linked lists to std::lists Jul 7, 2022
@vaughnbetz
Copy link
Contributor

@jmah76 : were these mostly / all fixed (in which case we should close this issue), or is keeping it around worthwhile?

Copy link

This issue has been inactive for a year and has been marked as stale. It will be closed in 15 days if it continues to be stale. If you believe this is still an issue, please add a comment.

@github-actions github-actions bot added the Stale label May 19, 2025
@vaughnbetz
Copy link
Contributor

Sending this to @AmirhosseinPoolad .... updae some of the clustering data structs to use std::vector and std::list etc. Some have already been done, but more remain.

@github-actions github-actions bot removed the Stale label May 20, 2025
@AmirhosseinPoolad
Copy link
Contributor

I ran clang-tidy to give me a list of all C-style arrays used in VPR. It's missing the heap allocated pointer arrays, still trying to find out if there's an easy way to list those. You can find results below.

https://gist.github.com/AmirhosseinPoolad/bee1015b11f165310e0861f5d81d54d7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants