Skip to content

VPR Pack: C-style Arrays to C++ Vectors #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmah76 opened this issue Jul 7, 2022 · 1 comment
Open

VPR Pack: C-style Arrays to C++ Vectors #2087

jmah76 opened this issue Jul 7, 2022 · 1 comment
Assignees
Labels

Comments

@jmah76
Copy link
Contributor

jmah76 commented Jul 7, 2022

Related to PR #2084
Change the C arrays in vpr/pack that get delete[] called on them to C++ vectors.

Using delete[] indicates that this is some sort of array which might be an opportunity to replace with std::array or std::vector depending on the context. The requirement for delete[] should be rare if we have such containers (like what you did above already successfully with the pin_timing etc. containers)
(From #2084 (comment))

could the hill_climbing_inputs_avail be a std::vector ? They are automatically 0 initialized and we just would call resize(helper_ctx.max_cluster_size + 1) here.
(From #2084 (comment))

@jmah76 jmah76 self-assigned this Jul 7, 2022
Copy link

This issue has been inactive for a year and has been marked as stale. It will be closed in 15 days if it continues to be stale. If you believe this is still an issue, please add a comment.

@github-actions github-actions bot added the Stale label May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant