Skip to content

VTR flow library documentation is just a skeleton -- should fill in #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vaughnbetz opened this issue Jun 9, 2022 · 8 comments · Fixed by #3080
Closed

VTR flow library documentation is just a skeleton -- should fill in #2059

vaughnbetz opened this issue Jun 9, 2022 · 8 comments · Fixed by #3080
Assignees
Labels
VTR Flow VTR Design Flow (scripts/benchmarks/architectures)

Comments

@vaughnbetz
Copy link
Contributor

https://docs.verilogtorouting.org/en/latest/vtr/python_libs/vtr/ has the skeleton of documentation for this library, but only the headings are there.

Proposed Behaviour

Complete the documentation

Context

Our flow scripts are pretty complex (and useful) so documenting them is helpful. We do have pretty reasonable documentation on the overall scripts, so if you conclude no documentation is needed on the library you could instead delete this documentation tab. But I suspect documentation here will be useful.

@vaughnbetz vaughnbetz added the VTR Flow VTR Design Flow (scripts/benchmarks/architectures) label Jun 9, 2022
Copy link

This issue has been inactive for a year and has been marked as stale. It will be closed in 15 days if it continues to be stale. If you believe this is still an issue, please add a comment.

@github-actions github-actions bot added the Stale label May 18, 2025
@vaughnbetz
Copy link
Contributor Author

@jgoeders : we should close this one out. We still have just a skeleton of documentation for the VTR flow library. If you or a delegate can fill it out some that would be best.

@jgoeders
Copy link
Contributor

@WhiteNinjaZ Could you work on documenting this?

@WhiteNinjaZ
Copy link
Contributor

Yea I can fill this in

@github-actions github-actions bot removed the Stale label May 20, 2025
@WhiteNinjaZ WhiteNinjaZ self-assigned this May 20, 2025
@WhiteNinjaZ
Copy link
Contributor

WhiteNinjaZ commented May 20, 2025

It looks like the documentation has been added already, at least when I build the docs locally, I get the generated docstrings for each of the functions. It looks like the web doc is still blank though. @vaughnbetz it is my understanding that the web docs are automatically updated with each PR?

@vaughnbetz
Copy link
Contributor Author

The CI automatically updates the docs. Not sure why they don't show up then ... I'm guessing there is something wrong with the doxyfile that says which ones to show on the web. See https://docs.verilogtorouting.org/en/latest/dev/code_documentation/
Possibly it is different for python ... our documentation on doxyfiles seems to be C++ focused. If you determine we should update the developer guide doxyfile section go ahead and do that too.

@vaughnbetz
Copy link
Contributor Author

In case what I wrote is confusing: to make the web docs we need to do two things:

@WhiteNinjaZ
Copy link
Contributor

@jgoeders

@jgoeders jgoeders linked a pull request May 23, 2025 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VTR Flow VTR Design Flow (scripts/benchmarks/architectures)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants