Skip to content

Collect parse_results*.txt as artifacts from CI to make it easier to update golden results #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vaughnbetz opened this issue Oct 7, 2021 · 2 comments
Assignees
Labels

Comments

@vaughnbetz
Copy link
Contributor

Right now when we fail a QoR check in CI due to an expected QoR change, the developer needs to rerun the test on his/her machine and run parse_vtr_task.py --create_golden to make a new expected QoR file (golden_results.txt).

We can simplify this by bringing back the parse_results*.txt files (currently parse_results.txt and parse_results2.txt is also used in some tests), and then the developer could just run parse_vtr_task.py --create_golden using those files.

Proposed Behaviour

Add parse_results*.txt as an artifact to bring back from CI.

Current Behaviour

We don't bring back those files.

Possible Solution

Update the file list for artifact capture.

Context

It's common to have to update QoR files; we should streamline the process. This would also avoid issues where the CI machines are slower or faster or have libraries that take more memory etc. than someone's server, by generating the new results in CI itself.

Copy link

This issue has been inactive for a year and has been marked as stale. It will be closed in 15 days if it continues to be stale. If you believe this is still an issue, please add a comment.

@github-actions github-actions bot added the Stale label May 17, 2025
@vaughnbetz
Copy link
Contributor Author

This was completed ... marking closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants