Skip to content

Parsing Architecture SB/CB depopulation doesn't handle newlines #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kmurray opened this issue Jun 26, 2015 · 5 comments
Closed

Parsing Architecture SB/CB depopulation doesn't handle newlines #17

kmurray opened this issue Jun 26, 2015 · 5 comments
Assignees

Comments

@kmurray
Copy link
Contributor

kmurray commented Jun 26, 2015

Originally reported on Google Code with ID 24

This is a very minor bug.

The architecture parser is very picky when parsing the SB/CB depopulation lists.

The following sample from architecture file will cause an error because the parser
has been coded to reject newlines:

<sb type="pattern">
    1 1 1 1 1
</sb>
<cb type="pattern">
    1 1 1 1
</cb>

The problem exists in read_xml_arch_file.c:2330.

Reported by jeffrey.goeders on 2012-05-10 16:14:50

@kmurray
Copy link
Contributor Author

kmurray commented Jun 26, 2015

Also, I believe tabs are rejected.

Reported by jeffrey.goeders on 2012-05-10 16:20:09

@kmurray kmurray self-assigned this Jun 26, 2015
@kmurray
Copy link
Contributor Author

kmurray commented Jun 26, 2015

Fix attached.

Reported by jeffrey.goeders on 2012-05-10 20:21:03

  • Status changed: Started

- _Attachment: [read_xml_arch_file.c](https://storage.googleapis.com/google-code-attachments/vtr-verilog-to-routing/issue-24/comment-2/read_xml_arch_file.c)_

@kmurray
Copy link
Contributor Author

kmurray commented Jun 26, 2015

Hi Jeff, just update the trunk directly.  You have commit privelages.

Reported by JasonKaiLuu on 2012-05-10 20:23:30

@kmurray
Copy link
Contributor Author

kmurray commented Jun 26, 2015

This change is in libvpr, and I don't believe I have commit privileges to the other
repository.

Reported by jeffrey.goeders on 2012-05-10 20:27:53

@kmurray
Copy link
Contributor Author

kmurray commented Jun 26, 2015

Change committed r262

Reported by jeffrey.goeders on 2012-05-25 16:05:07

  • Status changed: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant